Skip to content

Commit c7667b1

Browse files
authored
Fix permissions on Include (#488)
1 parent 0c415ee commit c7667b1

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

docs/en/docs/release-notes.md

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ hide:
2121

2222
- Internal pattern for OAuth2 form password.
2323
- Fixed internal typings of passthrough in Response and TemplateResponse.
24+
- Esmerald permissions on Include were being overriten by Lilya too early.
2425

2526
## 3.6.3
2627

esmerald/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
__version__ = "3.6.3"
1+
__version__ = "3.6.4"
22

33

44
from lilya import status

esmerald/routing/router.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -2878,7 +2878,6 @@ async def another(request: Request) -> str:
28782878

28792879
self.dependencies = dependencies or {}
28802880
self.interceptors: Sequence[Interceptor] = interceptors or []
2881-
self.permissions: Sequence[Permission] = permissions or [] # type: ignore
28822881
self.response_class = None
28832882
self.response_cookies = None
28842883
self.response_headers = None
@@ -2904,6 +2903,9 @@ async def another(request: Request) -> str:
29042903
redirect_slashes=redirect_slashes,
29052904
)
29062905

2906+
# Making sure Esmerald uses the Esmerald permission system and not Lilya's.
2907+
self.permissions: Sequence[Permission] = permissions or [] # type: ignore
2908+
29072909
def resolve_app_parent(self, app: Optional[Any]) -> Optional[Any]:
29082910
"""
29092911
Resolves the owner of ChildEsmerald or Esmerald iself.

0 commit comments

Comments
 (0)