Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the VerifyDotnetFolderContents test on all images #4845

Closed
lbussell opened this issue Aug 23, 2023 · 0 comments · Fixed by #5771
Closed

Run the VerifyDotnetFolderContents test on all images #4845

lbussell opened this issue Aug 23, 2023 · 0 comments · Fixed by #5771

Comments

@lbussell
Copy link
Contributor

The VerifyDotnetFolderContents test currently has incorrect conditions that may be causing it to not run on the majority of Linux platforms:

if (!IsPowerShellSupported(imageData, out string powerShellReason))
{
OutputHelper.WriteLine(powerShellReason);
return;
}
// Skip test on CBL-Mariner. Since installation is done via RPM package, we just need to verify the package installation
// was done (handled by VerifyPackageInstallation test). There's no need to check the actual contents of the package.
if (imageData.OS.Contains("cbl-mariner"))
{
return;
}
if (!imageData.SdkOS.StartsWith(OS.Alpine) && DockerHelper.IsLinuxContainerModeEnabled)
{
return;
}

In particular, Mariner hasn't relied on RPM installs since 6.0, and the !imageData.SdkOS.StartsWith(OS.Alpine) && DockerHelper.IsLinuxContainerModeEnabled condition seems completely incorrect. We should re-evaluate which platforms this test can be ran on and run it on as many as possible.

We should also run the test on (potentially) distroless images and platforms that don't support PowerShell.

@github-project-automation github-project-automation bot moved this to Backlog in .NET Docker Aug 23, 2023
@mthalman mthalman moved this from Backlog to Current Release in .NET Docker Aug 30, 2023
@lbussell lbussell moved this from Current Release to Sprint in .NET Docker Sep 20, 2023
@lbussell lbussell self-assigned this Sep 21, 2023
@lbussell lbussell moved this from Sprint to In Progress in .NET Docker Oct 2, 2023
@lbussell lbussell moved this from In Progress to Current Release in .NET Docker Dec 7, 2023
@lbussell lbussell removed their assignment Jun 13, 2024
@ellahathaway ellahathaway self-assigned this Aug 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Docker Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants