Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library doesn't implement error.id #17

Open
aljones15 opened this issue Nov 4, 2022 · 1 comment
Open

Library doesn't implement error.id #17

aljones15 opened this issue Nov 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@aljones15
Copy link
Contributor

Note: this is a bit speculative as VC-API 0.3 does not seem to have consensus on what the error objects should look like, but this is the current data structure:

id [string]
message [string]
details [object]

We return:

    name: 'ValidationError',
    message: "A validation error occured in the 'Initiate Exchange Request' validator.",
    details: { errors: [Array], httpStatusCode: 400 },
    cause: null,
    stack: "ValidationError: ...',
    type: 'ValidationError'

So when the error formats for the VC-API are formalized we will need to update this library and probably vc-delivery too.

@aljones15 aljones15 added the enhancement New feature or request label Nov 4, 2022
@dlongley
Copy link
Member

dlongley commented Nov 5, 2022

I'm not sure we want the errors to look like what's in the spec. We should decide if that's a good idea or if we should adopt a different format before making implementation changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants