Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config change endpoint to require no change to the meter controller if the meter ID changes #62

Open
dlongley opened this issue Aug 31, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@dlongley
Copy link
Member

No description provided.

@dlongley dlongley added the Priority 1 Critical label Aug 31, 2021
@dlongley
Copy link
Member Author

In order to allow the meter controller to change, we will require an additional zcap invocation (two http sigs) or that the invoker not be the controller of the keystore but the meter controller.

@dlongley
Copy link
Member Author

dlongley commented Nov 19, 2021

We want to make sure that the meter for a keystore config can't be changed in the current code base -- and we will figure out how to allow it to be changed in the future.

@dlongley
Copy link
Member Author

dlongley commented Nov 21, 2021

At present the meter cannot be changed in a keystore config:

https://github.com/digitalbazaar/bedrock-kms-http/blob/v10.0.0/lib/http.js#L195

I'm removing the Priority 1 label for this reason. This issue will be left open for when meter changing becomes possible to do safely in the future.

@dlongley dlongley added enhancement New feature or request and removed Priority 1 Critical labels Nov 21, 2021
@dlongley
Copy link
Member Author

Once changing the meter ID is possible, tests should be added. Closing #53 as duplicate. Minimal tests required:

  1. Change the meter ID and confirm a new meter is upserted when doing so
  2. Negative test that disallows meter with a different controller from the invoker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant