Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit a381088

Browse files
committedSep 4, 2020
docs: update examples to config v1beta9
1 parent 78cd475 commit a381088

File tree

15 files changed

+60
-54
lines changed

15 files changed

+60
-54
lines changed
 

‎cmd/open.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ devspace open
7777
}
7878

7979
openCmd.Flags().StringVar(&cmd.Provider, "provider", "", "The cloud provider to use")
80-
openCmd.Flags().IntVar(&cmd.Port, "port", 0, "The cloud provider to use")
80+
openCmd.Flags().IntVar(&cmd.Port, "port", 0, "The port on the localhost to listen on")
8181

8282
return openCmd
8383
}

‎cmd/ui.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func (cmd *UICmd) RunUI(f factory.Factory, cobraCmd *cobra.Command, args []strin
7373
}
7474

7575
// Search for an already existing server
76-
if cmd.ForceServer == false && cmd.Dev == false {
76+
if cmd.ForceServer == false && cmd.Dev == false && cmd.Host == "localhost" {
7777
checkPort := server.DefaultPort
7878
if cmd.Port != 0 {
7979
checkPort = cmd.Port
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
version: v1beta8
22
images:
33
default:
4-
image: dscr.io/${DEVSPACE_USERNAME}/devspace
4+
image: mydockeruser/devspace
55
createPullSecret: true
66
deployments:
77
- name: dependency1
88
helm:
99
componentChart: true
1010
values:
1111
containers:
12-
- image: dscr.io/${DEVSPACE_USERNAME}/devspace
12+
- image: mydockeruser/devspace
1313
dependencies:
1414
- source:
1515
path: ../dependency2

‎examples/hooks/devspace.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
version: v1beta5
1+
version: v1beta9
22
images:
33
default:
4-
image: dscr.io/${DEVSPACE_USERNAME}/devspace
4+
image: mydockeruser/devspace
55
deployments:
66
- name: my-deployment
77
helm:
88
componentChart: true
99
values:
1010
containers:
11-
- image: dscr.io/${DEVSPACE_USERNAME}/devspace
11+
- image: mydockeruser/devspace
1212
hooks:
1313
- command: echo
1414
args:

‎examples/kustomize/devspace.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version: v1beta5
1+
version: v1beta9
22
images:
33
default:
44
image: yourusername/devspace

‎examples/microservices/devspace.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# If you want to try this example in other
33
# Clusters you have to exchange the image names
44
# and enable image pushing
5-
version: v1beta5
5+
version: v1beta9
66
images:
77
node:
88
image: node

‎examples/minikube/devspace.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version: v1beta5
1+
version: v1beta9
22
images:
33
default:
44
image: devspace

‎examples/php-mysql-example/devspace.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
version: v1beta5
1+
version: v1beta9
22
images:
33
default:
4-
image: dscr.io/${DEVSPACE_USERNAME}/devspace
4+
image: mydockeruser/devspace
55
deployments:
66
- name: mysql
77
helm:
@@ -31,7 +31,7 @@ deployments:
3131
componentChart: true
3232
values:
3333
containers:
34-
- image: dscr.io/${DEVSPACE_USERNAME}/devspace
34+
- image: mydockeruser/devspace
3535
service:
3636
ports:
3737
- port: 80

‎examples/profiles/devspace.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
version: v1beta5
22
images:
33
service-image-1:
4-
image: dscr.io/${DEVSPACE_USERNAME}/service-1
4+
image: mydockeruser/service-1
55
dockerfile: service1/Dockerfile
66
context: service1/
77
createPullSecret: true
88
service-image-2:
9-
image: dscr.io/${DEVSPACE_USERNAME}/service-2
9+
image: mydockeruser/service-2
1010
dockerfile: service2/Dockerfile
1111
context: service2/
1212
createPullSecret: true
@@ -16,13 +16,13 @@ deployments:
1616
componentChart: true
1717
values:
1818
containers:
19-
- image: dscr.io/${DEVSPACE_USERNAME}/service-1
19+
- image: mydockeruser/service-1
2020
- name: service-2
2121
helm:
2222
componentChart: true
2323
values:
2424
containers:
25-
- image: dscr.io/${DEVSPACE_USERNAME}/service-2
25+
- image: mydockeruser/service-2
2626
commands:
2727
- name: dev-service1
2828
command: "devspace dev --profile=dev-service1"

‎examples/quickstart-kubectl/devspace.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
version: v1beta5
1+
version: v1beta9
22
images:
33
default:
4-
image: dscr.io/yourusername/quickstart
4+
image: mydockeruser/quickstart
55
deployments:
66
- name: devspace-default
77
kubectl:

‎examples/quickstart-kubectl/kube/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ spec:
1717
containers:
1818
- name: default
1919
# The correct image tag will be inserted during devspace dev / devspace deploy
20-
image: dscr.io/yourusername/quickstart
20+
image: mydockeruser/quickstart

‎examples/redeploy-instead-of-hot-reload/devspace.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version: v1beta5
1+
version: v1beta9
22
images:
33
default:
44
image: yourusername/devspace

‎pkg/devspace/dependency/resolver.go

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,13 @@ func (r *resolver) resolveDependency(basePath string, dependency *latest.Depende
230230
r.log.Donef("Pulled %s", ID)
231231
}
232232
} else if dependency.Source.Path != "" {
233-
localPath, err = filepath.Abs(filepath.Join(basePath, filepath.FromSlash(dependency.Source.Path)))
234-
if err != nil {
235-
return nil, errors.Wrap(err, "filepath absolute")
233+
if filepath.IsAbs(dependency.Source.Path) {
234+
localPath = dependency.Source.Path
235+
} else {
236+
localPath, err = filepath.Abs(filepath.Join(basePath, filepath.FromSlash(dependency.Source.Path)))
237+
if err != nil {
238+
return nil, errors.Wrap(err, "filepath absolute")
239+
}
236240
}
237241
}
238242

@@ -362,7 +366,10 @@ func (r *resolver) getDependencyID(basePath string, dependency *latest.Dependenc
362366
return id
363367
} else if dependency.Source.Path != "" {
364368
// Check if it's an git repo
365-
filePath := filepath.Join(basePath, dependency.Source.Path)
369+
filePath := dependency.Source.Path
370+
if !filepath.IsAbs(dependency.Source.Path) {
371+
filePath = filepath.Join(basePath, dependency.Source.Path)
372+
}
366373

367374
remote, err := git.GetRemote(filePath)
368375
if err == nil {

‎pkg/devspace/server/server.go

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -54,20 +54,24 @@ func NewServer(configLoader loader.ConfigLoader, config *latest.Config, generate
5454
if forcePort != nil {
5555
usePort = *forcePort
5656

57-
unused, err := port.CheckHostPort(host, usePort)
58-
if unused == false {
59-
return nil, errors.Errorf("Port %d already in use: %v", usePort, err)
60-
}
61-
} else {
62-
for i := 0; i < 20; i++ {
57+
if host == "localhost" {
6358
unused, err := port.CheckHostPort(host, usePort)
64-
if unused {
65-
break
59+
if unused == false {
60+
return nil, errors.Errorf("Port %d already in use: %v", usePort, err)
6661
}
67-
68-
usePort++
69-
if i+1 == 20 {
70-
return nil, err
62+
}
63+
} else {
64+
if host == "localhost" {
65+
for i := 0; i < 20; i++ {
66+
unused, err := port.CheckHostPort(host, usePort)
67+
if unused {
68+
break
69+
}
70+
71+
usePort++
72+
if i+1 == 20 {
73+
return nil, err
74+
}
7175
}
7276
}
7377
}
@@ -215,23 +219,6 @@ func (h *handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
215219
return
216220
}
217221

218-
if strings.HasPrefix(r.URL.Path, "/api/") {
219-
// check if we have a header or parameter
220-
auth, ok := r.Header["Authorization"]
221-
if !ok || len(auth) != 1 || auth[0] != h.token {
222-
// check if there is a parameter (used for websockets)
223-
token := r.URL.Query().Get("token")
224-
if token != h.token {
225-
w.WriteHeader(http.StatusUnauthorized)
226-
// h.log.Infof("%s: unauthorized access from %s", r.URL.Path, r.RemoteAddr)
227-
return
228-
}
229-
}
230-
}
231-
232-
// if r.URL != nil {
233-
// h.log.Infof("Incoming request at %s", r.URL.String())
234-
// }
235222
h.mux.ServeHTTP(w, r)
236223
}
237224

‎pkg/util/git/helper.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,24 @@ import (
44
"github.com/pkg/errors"
55
"gopkg.in/src-d/go-git.v4"
66
"os"
7+
"os/exec"
8+
"strings"
79
)
810

911
// GetHash retrieves the current HEADs hash
1012
func GetHash(localPath string) (string, error) {
1113
repo, err := git.PlainOpen(localPath)
1214
if err != nil {
15+
// last resort, try with cli
16+
if isGitCommandAvailable() {
17+
out, err := exec.Command("git", "rev-parse", "HEAD").CombinedOutput()
18+
if err != nil {
19+
return "", errors.Errorf("Error running 'git rev-parse HEAD': %v -> %s", err, string(out))
20+
}
21+
22+
return strings.TrimSpace(string(out)), nil
23+
}
24+
1325
return "", errors.Wrap(err, "git open")
1426
}
1527

0 commit comments

Comments
 (0)
Please sign in to comment.