Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devictoribero/clean-code-javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ryanmcdermott/clean-code-javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
27 contributors

Commits on Feb 2, 2019

  1. Added link to the new spanish translation

    @devictoribero
    devictoribero committed Feb 2, 2019
    Copy the full SHA
    ce1d383 View commit details

Commits on Feb 5, 2019

  1. Merge pull request ryanmcdermott#256 from tureey/feature/addSpanishTr… 

    …anslation

Added link to the new spanish translation
    @ryanmcdermott
    ryanmcdermott authored Feb 5, 2019
    Copy the full SHA
    5e866b7 View commit details

Commits on Feb 11, 2019

  1. Format using Prettier's Markdown formatter

    @ryanmcdermott
    ryanmcdermott authored Feb 11, 2019
    Copy the full SHA
    b1c3a6e View commit details

Commits on Mar 24, 2019

  1. Update README.md

    @gavbarosee
    gavbarosee authored Mar 24, 2019
    Copy the full SHA
    bcab32d View commit details

  2. Merge pull request ryanmcdermott#258 from GavBaros/master 

    Update README.md
    @ryanmcdermott
    ryanmcdermott authored Mar 24, 2019
    Copy the full SHA
    188f769 View commit details

Commits on Jul 23, 2019

  1. remove distracting reference in "testing single concept per test" 

    This distracted me from the code at hand, so I suggest changing the text to be more neutral.
    @Haroenv
    Haroenv authored Jul 23, 2019
    Copy the full SHA
    84205ae View commit details

  2. Merge pull request ryanmcdermott#261 from Haroenv/patch-1 

    remove distracting reference in "testing single concept per test"
    @ryanmcdermott
    ryanmcdermott authored Jul 23, 2019
    Copy the full SHA
    a6875f4 View commit details

Commits on Aug 5, 2019

  1. fix wrong syntax

    @tylim88
    tylim88 authored Aug 5, 2019
    Copy the full SHA
    bcb1526 View commit details

  2. Merge pull request ryanmcdermott#262 from tylim88/master 

    fix wrong syntax
    @ryanmcdermott
    ryanmcdermott authored Aug 5, 2019
    Copy the full SHA
    0461538 View commit details

Commits on Aug 8, 2019

  1. Update plain http link to https

    @Chengings
    Chengings committed Aug 8, 2019
    Copy the full SHA
    c7cd5c4 View commit details

  2. Merge pull request ryanmcdermott#263 from Chengings/master 

    Update plain http links to https
    @ryanmcdermott
    ryanmcdermott authored Aug 8, 2019
    Copy the full SHA
    4e15fde View commit details

Commits on Aug 21, 2019

  1. fix typo - Indonesian

    @oprogramador
    oprogramador authored Aug 21, 2019
    Copy the full SHA
    7b3107a View commit details

Commits on Aug 23, 2019

  1. Merge pull request ryanmcdermott#264 from oprogramador/patch-1 

    fix typo - Indonesian
    @ryanmcdermott
    ryanmcdermott authored Aug 23, 2019
    Copy the full SHA
    d31c5fb View commit details

Commits on Oct 25, 2019

  1. Some corrections in **Concurrency** section

    @Userbit
    Userbit authored Oct 25, 2019
    Copy the full SHA
    0f5326f View commit details

Commits on Oct 29, 2019

  1. Merge pull request ryanmcdermott#268 from Userbit/master 

    Some corrections in **Concurrency** section
    @ryanmcdermott
    ryanmcdermott authored Oct 29, 2019
    Copy the full SHA
    01bdbf0 View commit details

Commits on Nov 18, 2019

  1. Add Traditional Chinese

    @trylovetom
    trylovetom authored Nov 18, 2019
    Copy the full SHA
    12b6509 View commit details

  2. Merge pull request ryanmcdermott#272 from trylovetom/master 

    Added link to the traditional chinese translation
    @ryanmcdermott
    ryanmcdermott authored Nov 18, 2019
    Copy the full SHA
    b36557a View commit details

Commits on Nov 21, 2019

  1. Fixing bad code example for over-optimization

    @geekf
    geekf authored Nov 21, 2019
    Copy the full SHA
    0762d8f View commit details

Commits on Nov 22, 2019

  1. Merge pull request ryanmcdermott#273 from geekf/patch-1 

    Fixing bad code example for over-optimization
    @ryanmcdermott
    ryanmcdermott authored Nov 22, 2019
    Copy the full SHA
    e7968b7 View commit details

Commits on Jan 1, 2020

  1. Added source link for bengali translations

    Md. Sabbir Alam committed Jan 1, 2020
    Copy the full SHA
    425d4c9 View commit details

Commits on Jan 2, 2020

  1. Merge pull request ryanmcdermott#277 from InsomniacSabbir/master 

    Added source link for bengali translations
    @ryanmcdermott
    ryanmcdermott authored Jan 2, 2020
    Copy the full SHA
    1c0b20a View commit details

Commits on Jan 10, 2020

  1. Add advantage in function parameters

    @xSpoooK
    xSpoooK authored Jan 10, 2020
    Copy the full SHA
    4503a25 View commit details

Commits on Jan 18, 2020

  1. Added number separator for improve readability

    @behnammodi
    behnammodi authored Jan 18, 2020
    Copy the full SHA
    3afe391 View commit details

Commits on Jan 19, 2020

  1. Merge pull request ryanmcdermott#283 from uxitten/patch-1 

    Added numeric separator for improve readability
    @ryanmcdermott
    ryanmcdermott authored Jan 19, 2020
    Copy the full SHA
    0ff4aba View commit details

Commits on Jan 20, 2020

  1. Merge pull request ryanmcdermott#280 from oger-p/patch-4 

    Add advantage in function parameters
    @ryanmcdermott
    ryanmcdermott authored Jan 20, 2020
    Copy the full SHA
    54492ac View commit details

Commits on Jan 21, 2020

  1. Change argument name from inner variable name

    @sbimochan
    sbimochan authored Jan 21, 2020
    Copy the full SHA
    8491866 View commit details

  2. Update README.md 

    Small grammar correction.
    @justin0022
    justin0022 authored Jan 21, 2020
    Copy the full SHA
    ba9797e View commit details

  3. Update README.md 

    Small grammar correction
    @justin0022
    justin0022 authored Jan 21, 2020
    Copy the full SHA
    0ab8eba View commit details

  4. Merge pull request ryanmcdermott#289 from justin0022/patch-1 

    Update README.md
    @ryanmcdermott
    ryanmcdermott authored Jan 21, 2020
    Copy the full SHA
    2e808e2 View commit details

Commits on Jan 22, 2020

  1. sort translations

    @rudotriton
    rudotriton committed Jan 22, 2020
    Copy the full SHA
    c18b976 View commit details

  2. add armenian translation to the list

    @rudotriton
    rudotriton committed Jan 22, 2020
    Copy the full SHA
    a812aa9 View commit details

  3. Merge pull request ryanmcdermott#291 from rudotriton/master 

    Sort translations
    @ryanmcdermott
    ryanmcdermott authored Jan 22, 2020
    Copy the full SHA
    dd7e665 View commit details

Commits on Feb 7, 2020

  1. Fixed a small typo

    @ristomcintosh
    ristomcintosh authored Feb 7, 2020
    Copy the full SHA
    5f8daa0 View commit details

  2. Merge pull request ryanmcdermott#290 from justin0022/patch-2 

    Update README.md
    @ryanmcdermott
    ryanmcdermott authored Feb 7, 2020
    Copy the full SHA
    e6f9934 View commit details

  3. Add an underscore to "Use explanatory variables" 

    This makes the destructuring a little more readable
    @ristomcintosh
    ristomcintosh authored Feb 7, 2020
    Copy the full SHA
    c90b109 View commit details

Commits on Feb 12, 2020

  1. Merge pull request ryanmcdermott#297 from Risto-Mcintosh/patch-1 

    Fixed a small typo
    @ryanmcdermott
    ryanmcdermott authored Feb 12, 2020
    Copy the full SHA
    b8b16eb View commit details

Commits on Mar 26, 2020

  1. turkish added

    @bsonmez
    bsonmez committed Mar 26, 2020
    Copy the full SHA
    2edfeef View commit details

  2. Revert "turkish added" 

    This reverts commit 2edfeef.
    @bsonmez
    bsonmez committed Mar 26, 2020
    Copy the full SHA
    87185d9 View commit details

  3. Turkish added

    @bsonmez
    bsonmez committed Mar 26, 2020
    Copy the full SHA
    60a3357 View commit details

  4. Turkish Added

    @bsonmez
    bsonmez committed Mar 26, 2020
    Copy the full SHA
    1470b0b View commit details

Commits on Mar 29, 2020

  1. fix

    @bsonmez
    bsonmez committed Mar 29, 2020
    Copy the full SHA
    46869c8 View commit details

Commits on Mar 31, 2020

  1. Merge pull request ryanmcdermott#311 from bsonmez/master 

    Turkish added
    @ryanmcdermott
    ryanmcdermott authored Mar 31, 2020
    Copy the full SHA
    0dcac22 View commit details

Commits on Apr 1, 2020

  1. Fix calling animationModule in ISP bad example

    Denis authored Apr 1, 2020
    Copy the full SHA
    ec7baf2 View commit details

Commits on Apr 16, 2020

  1. Update README.md

    Oleksandr Zaychenko authored Apr 16, 2020
    Copy the full SHA
    9388808 View commit details

Commits on Apr 17, 2020

  1. Merge pull request ryanmcdermott#313 from mindfr1k/master 

    Ukrainian translation is added
    @ryanmcdermott
    ryanmcdermott authored Apr 17, 2020
    Copy the full SHA
    5f52d7d View commit details

Commits on May 3, 2020

  1. Merge pull request ryanmcdermott#312 from nebakry/patch-1 

    Fix calling animationModule in ISP bad example
    @ryanmcdermott
    ryanmcdermott authored May 3, 2020
    Copy the full SHA
    c56cc59 View commit details

Commits on Jul 31, 2020

  1. Merge pull request ryanmcdermott#288 from sbimochan/patch-1 

    Change argument name from inner variable name
    @ryanmcdermott
    ryanmcdermott authored Jul 31, 2020
    Copy the full SHA
    4d15e1c View commit details

Commits on Sep 6, 2020

  1. Add calculation for milliseconds in a day

    @ychek
    ychek authored Sep 6, 2020
    Copy the full SHA
    365717f View commit details

Commits on Oct 5, 2020

  1. Replace pass-by-reference with mutability, clean up 

    This edit only affects the Avoid Side Effects (part 2) section.
It replaces the discussion of pass by reference with an explanation in terms of mutability. 
By avoiding the confusing terminology and possible links to the implementation details of 
different JS engines the explanation can be kept at an abstraction level that's great for 
beginners and experts alike. I also cleaned up some grammar, typos, etc.
    @jdsandifer
    jdsandifer authored Oct 5, 2020
    Copy the full SHA
    3b9504e View commit details

Commits on Oct 6, 2020

  1. Merge pull request ryanmcdermott#323 from jdsandifer/issue-321-remove… 

    …-pass-by-reference

Replace pass-by-reference with mutability, clean up
    @ryanmcdermott
    ryanmcdermott authored Oct 6, 2020
    Copy the full SHA
    597a510 View commit details
Showing with 518 additions and 311 deletions.
  1. +518 −311 README.md
Loading