Skip to content

Commit 59e16e9

Browse files
brentleyjonescopybara-github
authored andcommitted
Show skipped tests as a warning
This matches the color used for the test outputs themselves. Closes bazelbuild#14235. PiperOrigin-RevId: 412987488
1 parent 5fd5afa commit 59e16e9

File tree

1 file changed

+21
-5
lines changed

1 file changed

+21
-5
lines changed

src/main/java/com/google/devtools/build/lib/runtime/TerminalTestResultNotifier.java

+21-5
Original file line numberDiff line numberDiff line change
@@ -272,14 +272,30 @@ public void notify(Set<TestSummary> summaries, int numberOfExecutedTargets) {
272272
}
273273

274274
private void addFailureToErrorList(List<String> list, String failureDescription, int count) {
275-
addToErrorList(list, "fails", "fail", failureDescription, count);
275+
addToList(list, AnsiTerminalPrinter.Mode.ERROR, "fails", "fail", failureDescription, count);
276276
}
277277

278-
private void addToErrorList(
278+
private void addToWarningList(
279279
List<String> list, String singularPrefix, String pluralPrefix, String message, int count) {
280+
addToList(list, AnsiTerminalPrinter.Mode.WARNING, singularPrefix, pluralPrefix, message, count);
281+
}
282+
283+
private void addToList(
284+
List<String> list,
285+
AnsiTerminalPrinter.Mode mode,
286+
String singularPrefix,
287+
String pluralPrefix,
288+
String message,
289+
int count) {
280290
if (count > 0) {
281-
list.add(String.format("%s%d %s %s%s", AnsiTerminalPrinter.Mode.ERROR, count,
282-
count == 1 ? singularPrefix : pluralPrefix, message, AnsiTerminalPrinter.Mode.DEFAULT));
291+
list.add(
292+
String.format(
293+
"%s%d %s %s%s",
294+
mode,
295+
count,
296+
count == 1 ? singularPrefix : pluralPrefix,
297+
message,
298+
AnsiTerminalPrinter.Mode.DEFAULT));
283299
}
284300
}
285301

@@ -316,7 +332,7 @@ private void printStats(TestResultStats stats) {
316332
addFailureToErrorList(results, "to build", stats.failedToBuildCount);
317333
addFailureToErrorList(results, "locally", stats.failedLocallyCount);
318334
addFailureToErrorList(results, "remotely", stats.failedRemotelyCount);
319-
addToErrorList(results, "was", "were", "skipped", stats.noStatusCount);
335+
addToWarningList(results, "was", "were", "skipped", stats.noStatusCount);
320336
printer.print(
321337
String.format(
322338
"\nExecuted %d out of %d %s: %s.\n",

0 commit comments

Comments
 (0)