Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jnigen] JNumber subclasses cannot be generated #2081

Open
HosseinYousefi opened this issue Mar 7, 2025 · 0 comments
Open

[jnigen] JNumber subclasses cannot be generated #2081

HosseinYousefi opened this issue Mar 7, 2025 · 0 comments

Comments

@HosseinYousefi
Copy link
Member

We could use toDartInteger and toDartDouble to match JString instead of adding the releaseOriginal parameter to existing methods like intValue or doubleValue. This also frees intValue() and such for the subclasses. Currently generating java.math.BigInteger fails since package:jni's JNumber has a intValue that does not have a releaseOriginal: true. We could potentially add this recursively to all of the subclasses as well (or simply not generate these methods as we know JNumber always exists.

A mechanism to modify the bindings of the dependent packages via the symbols file is nice to have nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant