Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jnigen] Generate classes in Java SDK without providing path #2082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[jnigen] Generate classes in Java SDK without providing path #2082

wants to merge 1 commit into from

Conversation

HosseinYousefi
Copy link
Member

Closes #2080

Now users can just add java.core classes like java.lang.StringBuilder to their classes and JNIgen will generate it from the bytecode available on the machine.

cc @jwill, this might be useful for you as well.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 88.6%. remained the same
when pulling a95dc4d on java-sdk
into 318f841 on main.

liamappelbe
liamappelbe approved these changes Mar 9, 2025
View reviewed changes
pkgs/jnigen/test/java_core_generation.dart
void main() {
test('Java core libraries are generated without providing class path',
() async {
await generateAndAnalyzeBindings(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't seem to check that the generated bindings contain the classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamappelbe liamappelbe liamappelbe approved these changes

Assignees
No one assigned
Labels
package:jnigen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jnigen] Generate classes in Java SDK without providing path
3 participants
@HosseinYousefi @coveralls @liamappelbe