ChartViewDelegate Function func chartValueSelected(_ chartView: ChartViewBase, entry: ChartDataEntry, highlight: Highlight) is not being called for every tap/touch inside the ChartView #4719

kiranGrg · 2021-09-20T07:33:08Z

I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?

I upgraded the Charts(iOS) version to 4.0.1 from 3.6.0 recently. Fixed all the changes in the codebase. Everything seems to be working except for one behavior on the chart.

What did you expect to happen?

Enabled the user interaction on the chart. Added the ChartViewDelegate, and implemented the optional delegate function
public func chartValueSelected(_ chartView: ChartViewBase, entry: ChartDataEntry, highlight: Highlight)

What happened instead?

However, apparently, this delegate function public func chartValueSelected(_ chartView: ChartViewBase, entry: ChartDataEntry, highlight: Highlight) is not being triggered every time when the tap inside the chart view (to be specific I was using LineChartView) is made, instead only for some places in the chart view seems to be responding to those touch events.

I am pretty, sure the delegate function used to be called without failing in Charts 3.6.0.

Additional Findings:

I tried the official demo version for iOS source codes for both 3.6.0 and 4.0.1, as I couldn't get this issue fixed. Looks like, the demo itself is exhibiting this problem, as I could see the delegate function being called with every tap/touch in 3.6.0 but not in the demo version 4.0.1

Charts Environment

Charts version/Branch/Commit Number: 4.0.1
Xcode version: 12.5.1
Swift version: 5.4.2
Platform(s) running Charts: iOS device/simulators
macOS version running Xcode: 11.5.2

The text was updated successfully, but these errors were encountered:

esma01 · 2021-09-20T18:09:58Z

I see the same issue. The sample project is also not working! Only the middle and last data points can be selected.

SergejLogis · 2021-09-22T08:30:45Z

Same here, 100% accurate description of an issue and the very same observations (Charts demo app)...

PhillipMaizza · 2021-09-22T11:17:30Z

I'm experiencing the same issue with line charts.

esma01 · 2021-09-22T13:10:23Z

@PhillipMaizza @SergejLogis Downgrading the charts to 3.6.0 worked for me!

SergejLogis · 2021-09-22T13:23:33Z

Yeah, that helped me as well. Only I didn't downgrade the entire library to 3.6.0, but instead created a custom LineChartDataSet with an overridden method:

class CustomLineChartDataSet: LineChartDataSet {

    override func entriesForXValue(_ xValue: Double) -> [ChartDataEntry] {
        var entries = [ChartDataEntry]()

        var low = startIndex
        var high = endIndex - 1

        while low <= high {
            var mid = (high + low) / 2
            var entry = self[mid]

            // if we have a match
            if xValue == entry.x {
                while mid > 0 && self[mid - 1].x == xValue {
                    mid -= 1
                }

                high = endIndex

                // loop over all "equal" entries
                while mid < high {
                    entry = self[mid]
                    if entry.x == xValue {
                        entries.append(entry)
                    } else {
                        break
                    }

                    mid += 1
                }

                break

            } else {
                if xValue > entry.x {
                    low = mid + 1
                } else {
                    high = mid - 1
                }
            }
        }

        return entries
    }

}

PhillipMaizza · 2021-09-22T14:12:41Z

I downgraded as well. Nice workaround though, @SergejLogis !

kcome · 2021-09-23T04:30:56Z

@liuxuan30 @jjatie Thanks for having a look at this PR that fixes this issue.

SergejLogis · 2021-09-24T09:07:54Z

@kcome I've tried your solution and it works like charm! 🥰 Much better than the one back-ported from 3.6.0. 🚀🙇‍♂️

hrvoje0099 · 2021-10-13T11:13:11Z

This repair does not solve the problem with Bar Charts. Exactly halfway up the bar is the boundary with select. If we press in the left half we will mark that bar, but if we press in the right half or nothing will happen or it will mark the second bar on the right. Its seems that the problem is in xValue. Eg. for coordinates x = 12, y = 50 returns -0.3 for xValue. @kcome

kcome · 2021-10-14T09:35:03Z

@hrvoje0099 are you using the pull-request branch here?
(or use https://github.com/kcome/Charts branch 4719-highlighter-fix in your project)
This ChartsDemo-iOS app video shows that PR branch has correct bar chart highlight.

screen-recording-2021-10-14-at-202737_bzAFQSeK.mp4

hrvoje0099 · 2021-10-14T11:45:17Z

@hrvoje0099 are you using the pull-request branch here? (or use https://github.com/kcome/Charts branch 4719-highlighter-fix in your project) This ChartsDemo-iOS app video shows that PR branch has correct bar chart highlight.

screen-recording-2021-10-14-at-202737_bzAFQSeK.mp4

I downloaded whole project (https://github.com/danielgindi/Charts) i run Demo app.
I added this changes from your fix in my projec:

but it didn't solve my bug completely, the problem I wrote above remained.
What else do I need to change to make it like yours ?
This is with your fix in demo, look last bar right half: https://www.screencast.com/t/sTnLLP7x

faaizdaglawala · 2022-03-25T16:04:56Z

@kcome I am facing crash in this solution.
after zooming the chart and then reloading the chart data crashes the app.

kcome · 2022-03-30T23:55:05Z

@kcome I am facing crash in this solution. after zooming the chart and then reloading the chart data crashes the app.

@faaizdaglawala I tested the demo app on simulator (xcode 13.3, iOS 15), I don't find crash after zooming and reloading chart data.
Could you give an example project and specific steps of reproducing it? Also could you give specific about "this solution"? Is it some comment in this issue discussion or a branch from some repo?

kcome · 2022-04-01T08:51:09Z

Hi @hrvoje0099 , I did another test and found the issue you described. And actually I just fixed it in another problem I encountered so today I merged the fix. If that suites you could you have a try? (this is the commit)
(sorry for late reply)

faaizdaglawala · 2022-04-01T12:22:47Z

@kcome I am facing crash in this solution. after zooming the chart and then reloading the chart data crashes the app.

@faaizdaglawala I tested the demo app on simulator (xcode 13.3, iOS 15), I don't find crash after zooming and reloading chart data. Could you give an example project and specific steps of reproducing it? Also could you give specific about "this solution"? Is it some comment in this issue discussion or a branch from some repo?

@kcome I had one chart view in which there are 2 lines in and then I reload that chart and add one line and one bar chart (CombinedChartView), now the scenario is when I zoom the chart when it is having one line and one bar chart (CombinedChartView), it works and then when I reload that chart to 2 lines then it crashes in subscript method saying index out of range

The crash is in ChartData file Swift/ContiguousArrayBuffer.swift:580: Fatal error: Index out of range
In blow method

public subscript(position: Index) -> Element { get { return dataSets[position] } set { self._dataSets[position] = newValue } }

This are the screenshot links of my charts
https://prnt.sc/Gzklfl20h_WC
https://prnt.sc/gTIj7I4Umn2a

kcome · 2022-04-03T07:16:18Z

@faaizdaglawala what you described in the comment and screenshots is probably another issue which is not related to this issue and the fix. I could reproduce a crash which is similar to your description, however the crash line is not the same as yours. Could you have a look at this #4798?

faaizdaglawala · 2022-04-04T10:51:55Z

@kcome understood your point but when I remove your changes, it starts working.

pavlo-kravchenko · 2022-04-05T14:42:15Z

@faaizdaglawala did you find a solution?

faaizdaglawala · 2022-04-06T05:47:06Z

@pavel-zlotarenchuk I downgraded the charts to version 3.6.0.

interactions(FIxes ChartsOrg#4719) Changed the entriesForXValue and entryIndex method in the ChartDataSet class to resolve ChartsOrg#4719. A few things were happening, entriesForXValue was using a predicate for the partition function that would never find the value it was looking for as it is giving you the correct location in the tree to start your search and not actually searching; hence why the values are rarely selected. The prefix array method for lazy rendering views also needs a different match predicate since the partitioned array has values that wont need to be highlighted. There is another additional change I made in this PR related to the closest logic for entryIndex; prior to this change it was grabbing the next index and not the closest. Example of the incorrect closest value: xValue = 6.2 would return back closest as 7 or even 12 whichever one was directly preceding its own index, now it returns the shortest distance between x values so it can be more accurate to the users touch.

dudenamedjune · 2022-04-23T08:35:15Z

Have a fix for this 😅 ... was a debugging rodeo

#4817

PorterHoskins · 2022-05-09T15:26:34Z

+1

PorterHoskins · 2022-05-09T15:27:00Z

~~Downgrading is not an option for people using SPM. It would be really nice to get this fix released.~~

zygoat · 2022-05-09T16:38:52Z

@PorterHoskins What prevents you from downgrading?

I import Charts from SPM; albeit my dependencies are configured in Xcode's pbxproj, but the equivalent in Packages.swift would be .upToNextMajor(from: "3.0.0") in the dependency spec.

PorterHoskins · 2022-05-09T17:15:48Z

Ok that worked... I was confused by the SPM support documentation in the 4.0 release. Sorry

pmairoldi · 2022-05-25T15:36:20Z

Closed by #4721

kcome mentioned this issue Sep 23, 2021

Highlighter fix #4721

Merged

tarasChernysh mentioned this issue Mar 29, 2022

chartValueSelected not calling for all clicking on hole in graph in v.4.0.2 (v3.6.0 works perfectly) #4804

Closed

kcome mentioned this issue Mar 30, 2022

Upgrading from 3.5.0 to 4.0.2 breaks highlighting #4805

Closed

dudenamedjune mentioned this issue Apr 23, 2022

fix(ChartDataSet): highlight not being invoked for expected user interactions #4719 #4817

Closed

This was referenced Apr 23, 2022

entriesForXValue() not finding point with matching xValue when it should #4668

Closed

Highlighting no longer works #4814

Closed

pmairoldi closed this as completed May 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ChartViewDelegate Function func chartValueSelected(_ chartView: ChartViewBase, entry: ChartDataEntry, highlight: Highlight) is not being called for every tap/touch inside the ChartView #4719

ChartViewDelegate Function func chartValueSelected(_ chartView: ChartViewBase, entry: ChartDataEntry, highlight: Highlight) is not being called for every tap/touch inside the ChartView #4719

kiranGrg commented Sep 20, 2021 •

edited

Loading

esma01 commented Sep 20, 2021

SergejLogis commented Sep 22, 2021 •

edited

Loading

PhillipMaizza commented Sep 22, 2021

esma01 commented Sep 22, 2021

SergejLogis commented Sep 22, 2021 •

edited

Loading

PhillipMaizza commented Sep 22, 2021

kcome commented Sep 23, 2021

SergejLogis commented Sep 24, 2021

hrvoje0099 commented Oct 13, 2021

kcome commented Oct 14, 2021

hrvoje0099 commented Oct 14, 2021 •

edited

Loading

faaizdaglawala commented Mar 25, 2022 •

edited

Loading

kcome commented Mar 30, 2022

kcome commented Apr 1, 2022

faaizdaglawala commented Apr 1, 2022 •

edited

Loading

kcome commented Apr 3, 2022

faaizdaglawala commented Apr 4, 2022

pavlo-kravchenko commented Apr 5, 2022

faaizdaglawala commented Apr 6, 2022

dudenamedjune commented Apr 23, 2022 •

edited

Loading

PorterHoskins commented May 9, 2022

PorterHoskins commented May 9, 2022 •

edited

Loading

zygoat commented May 9, 2022

PorterHoskins commented May 9, 2022

pmairoldi commented May 25, 2022

ChartViewDelegate Function func chartValueSelected(_ chartView: ChartViewBase, entry: ChartDataEntry, highlight: Highlight) is not being called for every tap/touch inside the ChartView #4719

ChartViewDelegate Function func chartValueSelected(_ chartView: ChartViewBase, entry: ChartDataEntry, highlight: Highlight) is not being called for every tap/touch inside the ChartView #4719

Comments

kiranGrg commented Sep 20, 2021 • edited Loading

What did you do?

What did you expect to happen?

What happened instead?

Additional Findings:

Charts Environment

esma01 commented Sep 20, 2021

SergejLogis commented Sep 22, 2021 • edited Loading

PhillipMaizza commented Sep 22, 2021

esma01 commented Sep 22, 2021

SergejLogis commented Sep 22, 2021 • edited Loading

PhillipMaizza commented Sep 22, 2021

kcome commented Sep 23, 2021

SergejLogis commented Sep 24, 2021

hrvoje0099 commented Oct 13, 2021

kcome commented Oct 14, 2021

hrvoje0099 commented Oct 14, 2021 • edited Loading

faaizdaglawala commented Mar 25, 2022 • edited Loading

kcome commented Mar 30, 2022

kcome commented Apr 1, 2022

faaizdaglawala commented Apr 1, 2022 • edited Loading

kcome commented Apr 3, 2022

faaizdaglawala commented Apr 4, 2022

pavlo-kravchenko commented Apr 5, 2022

faaizdaglawala commented Apr 6, 2022

dudenamedjune commented Apr 23, 2022 • edited Loading

PorterHoskins commented May 9, 2022

PorterHoskins commented May 9, 2022 • edited Loading

zygoat commented May 9, 2022

PorterHoskins commented May 9, 2022

pmairoldi commented May 25, 2022

kiranGrg commented Sep 20, 2021 •

edited

Loading

SergejLogis commented Sep 22, 2021 •

edited

Loading

SergejLogis commented Sep 22, 2021 •

edited

Loading

hrvoje0099 commented Oct 14, 2021 •

edited

Loading

faaizdaglawala commented Mar 25, 2022 •

edited

Loading

faaizdaglawala commented Apr 1, 2022 •

edited

Loading

dudenamedjune commented Apr 23, 2022 •

edited

Loading

PorterHoskins commented May 9, 2022 •

edited

Loading