Skip to content

Commit 5a9cee7

Browse files
committedMar 3, 2017
'docker daemon' deprecation message doesn't use the new versioning scheme
Signed-off-by: yuexiao-wang <[email protected]>
1 parent 7fb83eb commit 5a9cee7

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed
 

‎cli/command/system/info.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ func prettyPrintInfo(dockerCli *command.DockerCli, info types.Info) error {
271271
fmt.Fprintf(dockerCli.Out(), " %s\n", attribute)
272272
}
273273
// TODO: Engine labels with duplicate keys has been deprecated in 1.13 and will be error out
274-
// after 3 release cycles (1.16). For now, a WARNING will be generated. The following will
274+
// after 3 release cycles (17.12). For now, a WARNING will be generated. The following will
275275
// be removed eventually.
276276
labelMap := map[string]string{}
277277
for _, label := range info.Labels {

‎cmd/dockerd/daemon.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ func loadDaemonCliConfig(opts daemonOptions) (*config.Config, error) {
437437
// This is deprecated in 1.13, and, be removed after 3 release cycles.
438438
// The following will check the conflict of labels, and report a warning for deprecation.
439439
//
440-
// TODO: After 3 release cycles (1.16) an error will be returned, and labels will be
440+
// TODO: After 3 release cycles (17.12) an error will be returned, and labels will be
441441
// sanitized to consolidate duplicate key-value pairs (config.Labels = newLabels):
442442
//
443443
// newLabels, err := daemon.GetConflictFreeLabels(config.Labels)

‎daemon/config/config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ func Reload(configFile string, flags *pflag.FlagSet, reload func(*Config)) error
242242
// This is deprecated in 1.13, and, be removed after 3 release cycles.
243243
// The following will check the conflict of labels, and report a warning for deprecation.
244244
//
245-
// TODO: After 3 release cycles (1.16) an error will be returned, and labels will be
245+
// TODO: After 3 release cycles (17.12) an error will be returned, and labels will be
246246
// sanitized to consolidate duplicate key-value pairs (config.Labels = newLabels):
247247
//
248248
// newLabels, err := GetConflictFreeLabels(newConfig.Labels)

‎daemon/graphdriver/overlay/overlay.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ func Init(home string, options []string, uidMaps, gidMaps []idtools.IDMap) (grap
146146
return nil, err
147147
}
148148
if !supportsDType {
149-
// not a fatal error until v1.16 (#27443)
149+
// not a fatal error until v17.12 (#27443)
150150
logrus.Warn(overlayutils.ErrDTypeNotSupported("overlay", backingFs))
151151
}
152152

‎daemon/graphdriver/overlay2/overlay.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func Init(home string, options []string, uidMaps, gidMaps []idtools.IDMap) (grap
172172
return nil, err
173173
}
174174
if !supportsDType {
175-
// not a fatal error until v1.16 (#27443)
175+
// not a fatal error until v17.12 (#27443)
176176
logrus.Warn(overlayutils.ErrDTypeNotSupported("overlay2", backingFs))
177177
}
178178

‎daemon/graphdriver/overlayutils/overlayutils.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ func ErrDTypeNotSupported(driver, backingFs string) error {
1313
if backingFs == "xfs" {
1414
msg += " Reformat the filesystem with ftype=1 to enable d_type support."
1515
}
16-
msg += " Running without d_type support will no longer be supported in Docker 1.16."
16+
msg += " Running without d_type support will no longer be supported in Docker 17.12."
1717
return errors.New(msg)
1818
}

0 commit comments

Comments
 (0)
Please sign in to comment.