Remove unused JS methods & npm dependencies

Author: pierlon

assets/src/common/components/select-media-frame.js

@@ -11,7 +11,7 @@ import { __, sprintf } from '@wordpress/i18n';
 /**
  * Internal dependencies
  */
-import { enforceFileSize, enforceFileType, getNoticeTemplate, mediaLibraryHasTwoNotices } from '../helpers';
+import { enforceFileType, getNoticeTemplate } from '../helpers';
 
 const { wp } = window;
 
@@ -159,13 +159,6 @@ export const EnforcedFileToolbarSelect = wp.media.view.Toolbar.Select.extend( {
 		const attachment = selection.models[ 0 ];
 
 		enforceFileType.call( this, attachment, SelectionFileTypeError );
-		enforceFileSize.call( this, attachment, SelectionFileSizeError );
-
-		// If there are two notices, like for wrong size and type, prevent the notices from covering the media.
-		const mediaFrame = this.$el.parents( '.media-frame' );
-		if ( mediaFrame ) {
-			mediaFrame.toggleClass( 'has-two-notices', mediaLibraryHasTwoNotices.call( this ) );
-		}
 	},
 } );
 

assets/src/common/constants.js

@@ -2,7 +2,4 @@
 export const MIN_FONT_SIZE = 6;
 export const MAX_FONT_SIZE = 72;
 export const MINIMUM_FEATURED_IMAGE_WIDTH = 1200;
-export const MEGABYTE_IN_BYTES = 1000000;
-export const VIDEO_ALLOWED_MEGABYTES_PER_SECOND = 1;
 export const FILE_TYPE_ERROR_VIEW = 'select-file-type-error';
-export const FILE_SIZE_ERROR_VIEW = 'select-file-size-error';

assets/src/common/helpers/index.js

@@ -1,27 +1,21 @@
 /**
  * External dependencies
  */
-import { get, has, now, reduce, template } from 'lodash';
+import { get, now, template } from 'lodash';
 
 /**
  * WordPress dependencies
  */
 import { __, sprintf } from '@wordpress/i18n';
-import { getColorObjectByAttributeValues, getColorObjectByColorValue } from '@wordpress/block-editor';
 
 /**
  * Internal dependencies
  */
 import {
-	FILE_SIZE_ERROR_VIEW,
 	FILE_TYPE_ERROR_VIEW,
-	MEGABYTE_IN_BYTES,
 	MINIMUM_FEATURED_IMAGE_WIDTH,
-	VIDEO_ALLOWED_MEGABYTES_PER_SECOND,
 } from '../constants';
 
-const allowedVideoMimeTypes = [ 'video/mp4' ];
-
 /**
  * Determines whether whether the image has the minimum required dimensions.
  *
@@ -111,71 +105,6 @@ export const validateFeaturedImage = ( media, dimensions, required ) => {
 	return 0 === errors.length ? null : errors;
 };
 
-/**
- * Converts a hexadecimal color to its RGBA form.
- *
- * @param {string} hex     Hex value.
- * @param {number} opacity Opacity.
- *
- * @return {Object} Rgba value.
- */
-export const getRgbaFromHex = ( hex, opacity = 100 ) => {
-	if ( ! hex ) {
-		return [];
-	}
-
-	hex = hex.replace( '#', '' );
-
-	if ( hex.length === 3 ) {
-		// If this is a 3 digit color, e.g. #f00, make it 6 digits by duplicating each one.
-		hex = `${ hex.charAt( 0 ) }${ hex.charAt( 0 ) }${ hex.charAt( 1 ) }${ hex.charAt( 1 ) }${ hex.charAt( 2 ) }${ hex.charAt( 2 ) }`;
-	}
-
-	const r = parseInt( hex.substring( 0, 2 ), 16 );
-	const g = parseInt( hex.substring( 2, 4 ), 16 );
-	const b = parseInt( hex.substring( 4, 6 ), 16 );
-
-	// Opacity needs to be in the range of 0-100.
-	opacity = Math.min( 100, Math.max( 0, opacity ) );
-
-	return [
-		r,
-		g,
-		b,
-		opacity / 100,
-	];
-};
-
-/**
- * Returns a CSS background-color property based on passed color and available colors.
- *
- * Either backgroundColor or customBackgroundColor should be passed, not both.
- *
- * @param {Object[]} colors                Array of color objects as set by the theme or by the editor defaults.
- * @param {?Object}  backgroundColor       Color object.
- * @param {?string}  backgroundColor.name  Color name.
- * @param {?string}  backgroundColor.slug  Color slug.
- * @param {?string}  backgroundColor.color Color value.
- * @param {?string}  customBackgroundColor A string containing the custom color value.
- * @param {?number}  opacity               Opacity.
- *
- * @return {?string} Background color string or undefined if no color has been set / found.
- */
-export const getBackgroundColorWithOpacity = ( colors, backgroundColor, customBackgroundColor, opacity = undefined ) => {
-	// Order: 1. Existing colors as set by the theme. 2. Custom color objects. 3. Custom background color.
-	const colorObject = backgroundColor ?
-		( getColorObjectByColorValue( colors, backgroundColor.color ) || getColorObjectByAttributeValues( colors, backgroundColor.slug, backgroundColor.color || customBackgroundColor ) ) :
-		{ color: customBackgroundColor };
-
-	if ( colorObject && colorObject.color ) {
-		const [ r, g, b, a ] = getRgbaFromHex( colorObject.color, opacity );
-
-		return `rgba(${ r }, ${ g }, ${ b }, ${ a })`;
-	}
-
-	return undefined;
-};
-
 /**
  * Gets the compiled template for a given notice message.
  *
@@ -216,11 +145,7 @@ export const isFileTypeAllowed = ( attachment, allowedTypes ) => {
 		return false;
 	}
 
-	if ( 'video' === fileType && ! allowedVideoMimeTypes.includes( mimeType ) ) {
-		return false;
-	}
-
-	return true;
+	return 'video' !== fileType;
 };
 
 /**
@@ -256,94 +181,6 @@ export const enforceFileType = function( attachment, SelectionError ) {
 	}
 };
 
-/**
- * If the attachment has the wrong file size, this displays a notice in the Media Library and disables the 'Select' button.
- *
- * This is not an arrow function so that it can be called with enforceFileSize.call( this, foo, bar ).
- *
- * @param {Object} attachment The selected attachment.
- * @param {Object} SelectionError The error to display.
- */
-export const enforceFileSize = function( attachment, SelectionError ) {
-	if ( ! attachment ) {
-		return;
-	}
-
-	const isVideo = 'video' === get( attachment, [ 'media_type' ], null ) || 'video' === get( attachment, [ 'attributes', 'type' ], null );
-
-	// If the file type is 'video' and its size is over the limit, display a notice in the Media Library.
-	if ( isVideo && isVideoSizeExcessive( getVideoBytesPerSecond( attachment ) ) ) {
-		this.secondary.set(
-			FILE_SIZE_ERROR_VIEW,
-			new SelectionError( {
-				actualVideoMegabytesPerSecond: Math.round( getVideoBytesPerSecond( attachment ) / MEGABYTE_IN_BYTES ),
-				maxVideoMegabytesPerSecond: VIDEO_ALLOWED_MEGABYTES_PER_SECOND,
-			} ),
-		);
-	} else {
-		this.secondary.unset( FILE_SIZE_ERROR_VIEW );
-	}
-};
-
-/**
- * Gets whether the Media Library has two notices.
- *
- * It's possible to have a notice that the file type and size are wrong.
- * In that case, this will need different styling, so the notices don't overlap the media.
- *
- * @return {boolean} Whether the Media Library has two notices.
- */
-export const mediaLibraryHasTwoNotices = function() {
-	return Boolean( this.secondary.get( FILE_TYPE_ERROR_VIEW ) ) && Boolean( this.secondary.get( FILE_SIZE_ERROR_VIEW ) );
-};
-
-/**
- * Gets whether the video file size is over a certain amount of bytes per second.
- *
- * @param {number} videoSize Video size per second, in bytes.
- * @return {boolean} Whether the file size is more than a certain amount of MB per second, or null of the data isn't available.
- */
-export const isVideoSizeExcessive = ( videoSize ) => {
-	return videoSize > VIDEO_ALLOWED_MEGABYTES_PER_SECOND * MEGABYTE_IN_BYTES;
-};
-
-/**
- * Gets the number of seconds in a colon-separated time string, like '01:10'.
- *
- * @param {string} time A colon-separated time, like '0:12'.
- * @return {number} seconds The number of seconds in the time, like 12.
- */
-export const getSecondsFromTime = ( time ) => {
-	const minuteInSeconds = 60;
-	const splitTime = time.split( ':' );
-
-	return reduce(
-		splitTime,
-		( totalSeconds, timeSection, index ) => {
-			const parsedTimeSection = isNaN( parseInt( timeSection ) ) ? 0 : parseInt( timeSection );
-			const distanceFromRight = splitTime.length - 1 - index;
-			const multiple = Math.pow( minuteInSeconds, distanceFromRight ); // This should be 1 for seconds, 60 for minutes, 360 for hours...
-			return totalSeconds + ( multiple * parsedTimeSection );
-		},
-		0,
-	);
-};
-
-/**
- * Given a URL, returns file size in bytes.
- *
- * @param {string} url URL to a file.
- * @return {Promise<number>} File size in bytes.
- */
-export const getContentLengthFromUrl = async ( url ) => {
-	const { fetch } = window;
-
-	const response = await fetch( url, {
-		method: 'head',
-	} );
-	return Number( response.headers.get( 'content-length' ) );
-};
-
 /**
  * Sets the featured image, on selecting it in the Media Library.
  *