-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify minor/patch version for clang-format #292
Comments
If you install the version that you want to use before running cpp-linter, then it should use that version as long as the major version number matches the I'm not sure if we can support this request. On Linux runners, we use the official installer script from LLVM which uses |
I think your problem might be solved by simply running
before running cpp-linter. |
|
It seems a regression (specific to building I doubt GitHub actions will update their image for the same reason. I sincerely hope I'm wrong though. Alternatively, you can install the latest v18 using the same LLVM install script we use. VERSION=18
wget https://apt.llvm.org/llvm.sh -O ${{ runner.temp }}/llvm_install.sh
chmod +x ${{ runner.temp }}/llvm_install.sh
if sudo ${{ runner.temp }}/llvm_install.sh $VERSION; then
sudo apt-get install -y clang-format-$VERSION clang-tidy-$VERSION
# for compatibility with cpp-linter-action, we must remove the added PPA
sudo rm /etc/apt/sources.list.d/*llvm*.list
fi And then run cpp-linter-action after that. |
Is your idea related to an existing feature?
version
Describe the behavior you would like
First of all I'm not sure that my request can be solved from cpp-linter side, but I hope it may.
When I use Github runner
ubuntu-22.04
and setversion: '18'
for cpp-linter, then during linter run version18.1.8
is installed because there is no installed clang-format-18 on that image.At the same time if I use
ubuntu-24.04
(currently-latest
) I got preinstalled clang-format 18.1.3.Is there a way to use 18.1.8 for ubuntu-24.04 runner as well using only cpp-linter-action settings?
It looks weird that we have old clang-format version for new ubuntu, and new clang-format for old ubuntu.
Describe alternatives you have considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: