-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bottom up path validation #345
Comments
tagging for akash This is very useful for helping spot invalid config files which would likely lead to very confusing errors from the relayer. This should also handle cases where the connection identifier defined doesn't have the specified parameters (the client ID doesn't match with that for the defined connection ID) |
We are looking on this. |
@colin-axner, From where do we need to check existing connections or channels, from config or querying from chain? |
If the configuration sets a client/connection/channel, the code needs to ensure that the set identifiers makes sense and that they exist. If a configuration sets a channel identifier, but not a client identifier, this is wrong, as per bottom up validation. Channels must have an associated client so therefore the config should ensure that client identifier is set. If a configuration sets a connection ID, but that connection does not exist on chain, we should return an error These are specific examples, but that's the general idea |
The current code does little path validation since the required identifiers recently changed in #334
This should be implemented as @AdityaSripal specifies in this comment
The text was updated successfully, but these errors were encountered: