From bc2ce127fb0a322bb127e8438bedd906ad787235 Mon Sep 17 00:00:00 2001
From: Chris Ricketts <chris_ricketts@protonmail.com>
Date: Fri, 24 May 2024 17:58:24 +0100
Subject: [PATCH 1/2] fix(client): write unbonding period advisory to stderr
instead of stdout
---
x/ccv/provider/client/proposal_handler.go | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/x/ccv/provider/client/proposal_handler.go b/x/ccv/provider/client/proposal_handler.go
index bb88276393..022d131e4d 100644
--- a/x/ccv/provider/client/proposal_handler.go
+++ b/x/ccv/provider/client/proposal_handler.go
@@ -363,7 +363,8 @@ func CheckPropUnbondingPeriod(clientCtx client.Context, propUnbondingPeriod time
providerUnbondingTime := res.Params.UnbondingTime
if providerUnbondingTime < propUnbondingPeriod {
- fmt.Printf(
+ fmt.Fprintf(
+ os.Stderr,
`consumer unbonding period is advised to be smaller than provider unbonding period, but is longer.
This is not a security risk, but will effectively lengthen the unbonding period on the provider.
consumer unbonding: %s
From 8ae6ac4b9e7e94eec5a0db94bbcb86e05e134c95 Mon Sep 17 00:00:00 2001
From: Philip Offtermatt <p.offtermatt@gmail.com>
Date: Mon, 27 May 2024 15:54:26 +0200
Subject: [PATCH 2/2] Add changelog for unbonding period advisory
---
.changelog/unreleased/bug-fixes/1921-write-stderr.md | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 .changelog/unreleased/bug-fixes/1921-write-stderr.md
diff --git a/.changelog/unreleased/bug-fixes/1921-write-stderr.md b/.changelog/unreleased/bug-fixes/1921-write-stderr.md
new file mode 100644
index 0000000000..665ef78024
--- /dev/null
+++ b/.changelog/unreleased/bug-fixes/1921-write-stderr.md
@@ -0,0 +1,2 @@
+- Write unbonding period advisory to stderr instead of stdout
+ ([\#1921](https://github.com/cosmos/interchain-security/pull/1921))
\ No newline at end of file