Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ValidatorUpdates in x/staking and x/gentutil #19736

Closed
julienrbrt opened this issue Mar 12, 2024 · 1 comment
Closed

Use ValidatorUpdates in x/staking and x/gentutil #19736

julienrbrt opened this issue Mar 12, 2024 · 1 comment
Assignees

Comments

@julienrbrt
Copy link
Member

#19735 migrated the legacy HasABCIGenesis and HasABCIEndblock api to use appmodule.ValidatorUpdates.

Only staking and genutil are implementing these interfaces. After #19735 we should update x/gentutil and x/staking keeper to directly return ValidatorUpdates in their keeper instead of doing the conversion in their module.go.

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Mar 12, 2024
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Legacy Mar 12, 2024
@julienrbrt julienrbrt added good first issue C:x/staking C:x/genutil genutil module issues and removed needs-triage Issue that needs to be triaged labels Mar 12, 2024
@chixiaowen
Copy link
Contributor

let me try @julienrbrt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants