Skip to content
This repository was archived by the owner on May 7, 2021. It is now read-only.

Commit 01cd295

Browse files
committedOct 3, 2019
platform/unprivqemu: Drop restrict=yes
Denying external network access indirectly breaks the `podman.go` tests because podman uses bridging by default, expecting `/etc/resolv.conf` to exist on the host and dying messily if it isn't. I don't know of a reason for us to do this by default - probably what we should do is something like only use `restrict=yes` for tests that aren't flagged as requiring network. But for now, let's make unprivqemu work like the other platforms by default. (As much as it can; this uses usermode TCP which has weird limitations like no ICMP, and bugs of course, but it does mostly work for what we need)
1 parent de86c1e commit 01cd295

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎platform/machine/unprivqemu/cluster.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func (qc *Cluster) NewMachineWithOptions(userdata *conf.UserData, options platfo
101101

102102
qc.mu.Lock()
103103

104-
qmCmd = append(qmCmd, "-netdev", "user,id=eth0,restrict=yes,hostfwd=tcp:127.0.0.1:0-:22", "-device", platform.Virtio(qc.flight.opts.Board, "net", "netdev=eth0"))
104+
qmCmd = append(qmCmd, "-netdev", "user,id=eth0,hostfwd=tcp:127.0.0.1:0-:22", "-device", platform.Virtio(qc.flight.opts.Board, "net", "netdev=eth0"))
105105

106106
plog.Debugf("NewMachine: %q", qmCmd)
107107

0 commit comments

Comments
 (0)
This repository has been archived.