Skip to content
This repository was archived by the owner on Mar 27, 2019. It is now read-only.

--dev incompatible inside chrome extensions #226

Closed
timoxley opened this issue Jan 10, 2013 · 9 comments
Closed

--dev incompatible inside chrome extensions #226

timoxley opened this issue Jan 10, 2013 · 9 comments

Comments

@timoxley
Copy link
Contributor

Just FYI, if you try to use files built with component build --dev in a chrome extension, you'll get an error like the following:

Uncaught Error: Code generation from strings disallowed for this context

Workaround for now is to remove the --dev, and deal with the lack of sourcemaps etc.

This is probably more an issue with component-builder

@tj
Copy link
Contributor

tj commented Jan 11, 2013

oh lame :(

@edmellum
Copy link

This could be fixed by using sourcemap instead of SourceURL since sourcemap doesn't require an eval. However sourcemaps aren't really supported that well in current debug tools so variables aren't mapped back properly.

@tj
Copy link
Contributor

tj commented Jan 18, 2013

sourcemaps are huge PITA too, I guess we could have a --no-source-url flag or something :s haha

@edmellum
Copy link

Having source URLs behind a flag is nice for IE debugging too. Or maybe someone should make a builder that spits out <script> tags or something.

@tj
Copy link
Contributor

tj commented Jan 18, 2013

a lot more work for no gain really, if you're using coffeescript or something sure, but I sure wouldn't bother with js

@tj
Copy link
Contributor

tj commented Jan 18, 2013

I guess, I dont find it to be a problem without

@bestander
Copy link

+1 for debugging in production, especially with all the line numbers preserved it helps to send bug reports for 3rd party components

@gjohnson
Copy link
Contributor

@jonathanong
Copy link
Contributor

closing this and moving discussion to componentjs/builder2.js#26

if you guys know a really simple library that easily makes source maps from just concatenating stuff, let me know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants