feat(date-inputs): add tooltip to "today" button #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
changed the title
tdeekens
approved these changes
Jul 3, 2019
montezume
added
👨🎨 Status: UI/UX Review
montezume
commented
Jul 3, 2019
| import messages from './messages'; | ||
|
|
||
| const WrapperComponent = styled.div` | ||
| display: flex; |
There was a problem hiding this comment.
this is required because the default wrapper is display: inline-block
montezume
commented
Jul 3, 2019
| @@ -6,6 +6,11 @@ | |||
| "UIKit.AsyncSelectInput.noOptionsMessageWithInputValue": "", | |||
| "UIKit.AsyncSelectInput.noOptionsMessageWithoutInputValue": "", | |||
| "UIKit.AsyncSelectInput.placeholder": "Auswählen...", | |||
| "UIKit.CalendarHeader.nextMonthTooltip": "nächstes Monat", | |||
|
FYI I opened a JIRA ticket for the missing translations. |
|
Is it okay from your side @Shecki ? |
|
yes, it's fine |
jonnybel
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds tooltip for the
todaybutton for DateInputs.Limitations
Because the header is quite small, we cannot use placement "top" or placement "left", as there isn't enough space, so the positioning library (popper) will automatically place it on the bottom.