Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(field-icon): do not scale icon when long hint #878

Merged
merged 1 commit into from
Jun 21, 2019
Merged

fix(field-icon): do not scale icon when long hint #878

merged 1 commit into from
Jun 21, 2019

Conversation

montezume
Copy link
Contributor

@montezume montezume commented Jun 19, 2019 •
edited
Loading

Summary

Currently, when there is a long hint text, the icon scales to become tiny.

Screen Shot 2019-06-19 at 4 11 36 PM

You can check the Percy diff for the new version

@montezume montezume self-assigned this Jun 19, 2019
@montezume montezume added the 🐛 Type: Bug Something isn't working label Jun 19, 2019
tdeekens
tdeekens approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sie sind der bester junger Herr. Haben Sie tausend Dank!

@montezume montezume merged commit 1c06bbc into master Jun 21, 2019
@montezume montezume deleted the ml-fix-hint-iocn branch June 21, 2019 09:40
@montezume montezume removed the request for review from filippobocik June 21, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@jonnybel jonnybel jonnybel approved these changes

Assignees

@montezume montezume

Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montezume @tdeekens @jonnybel