feat(storybook): add addon-a11y #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
approved these changes
Jun 7, 2019
|
@tdeekens one issue is that our brand color has bad color contrast, so pretty much every component will have this error 😢 |
Can we add exceptions? Not sure that will change but maybe we can raise it? |
|
@tdeekens not really, I'm afraid at this phase it would complain too much to the point of becoming annoying 🤔 |
jonnybel
force-pushed
the
ja-add-a11y-addon
branch
from
1deb63d to
35a91c5
Compare
|
@jonnybel do you want to merge this 😄 |
|
I can't, I'm not authorized 😬 |
|
Looks unauthorized to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of the new features of storybook 5.1 (#839), this PR adds the new Real-Time accessibility testing addon.
Example: