feat: add version export #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
requested review from
emmenko and
tdeekens
and removed request for
emmenko
tdeekens
reviewed
Jun 6, 2019
| @@ -18,6 +18,9 @@ const configureRollupPlugins = (options = {}) => | |||
| [ | |||
| replace({ | |||
| 'process.env.NODE_ENV': JSON.stringify('production'), | |||
| 'process.env.npm_package_version': JSON.stringify( | |||
| process.env.npm_package_version | |||
| ), | |||
There was a problem hiding this comment.
Nice. If this works I'll simplify app-kit again too again.
There was a problem hiding this comment.
But we don't use lerna here for bumping versions... I think that's why we can have this simpler
There was a problem hiding this comment.
screenshot of cjs file
tdeekens
approved these changes
Jun 6, 2019
montezume
commented
Jun 6, 2019
| @@ -9,6 +9,12 @@ describe('exports', () => { | |||
| expect(customProperties).toBeTruthy(); | |||
| }); | |||
|
|
|||
| describe('version', () => { | |||
| it('should match package.json version', () => { | |||
| expect(version).toMatch(process.env.npm_package_version); | |||
There was a problem hiding this comment.
or should I directly import from package.json 🤔
tdeekens
approved these changes
Jun 6, 2019
| @@ -9,6 +9,12 @@ describe('exports', () => { | |||
| expect(customProperties).toBeTruthy(); | |||
| }); | |||
|
|
|||
| describe('version', () => { | |||
| it('should match package.json version', () => { | |||
| expect(version).toMatch(process.env.npm_package_version); | |||
jonnybel
approved these changes
Jun 6, 2019
emmenko
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Like similar PRs in App Kit, we also add a version export 😄