Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toggle-input): toggle input disabled styles #832

Merged
merged 1 commit into from
Jun 5, 2019
Merged

fix(toggle-input): toggle input disabled styles #832

merged 1 commit into from
Jun 5, 2019

Conversation

jonnybel
Copy link
Contributor

@jonnybel jonnybel commented Jun 4, 2019 •
edited
Loading

Fixes the following reported bugs on the ToggleInput component for when it is disabled:

  • The handler (thumb-color) should be grey instead of white
  • The track shadow (the inner part) should be NONE. Right now there is a shadow.

Also fixes the styles for when the input is disabled and checked.

@jonnybel jonnybel added 🐛 Type: Bug Something isn't working Semver: FIX labels Jun 4, 2019
@jonnybel jonnybel requested a review from montezume June 4, 2019 15:32
@montezume montezume requested a review from mariabarrena June 4, 2019 15:36
@montezume montezume added the 👨‍🎨 Status: UI/UX Review Requires review from design team label Jun 4, 2019
@montezume montezume requested review from franzi-t and removed request for mariabarrena June 4, 2019 15:37
@montezume montezume removed the request for review from franzi-t June 4, 2019 15:38
montezume
montezume approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@montezume montezume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we need UX review. I'm not sure who to assign. I think @franzi-t is on vacation

@montezume
Copy link
Contributor

@mariabarrena can you look at the Percy diff and netlify deploy tomorrow? Thanks

tdeekens
tdeekens approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks cool. VRT approval pending.

@mariabarrena
Copy link
Contributor

Percy checked. All approved.

@montezume montezume merged commit 2ae602e into master Jun 5, 2019
@montezume montezume deleted the ja-fix-toggle-disabled-styles branch June 5, 2019 07:45
montezume added a commit that referenced this pull request Jun 5, 2019
@montezume
Revert "fix(toggle-input): toggle input disabled styles (#832)"
cd03707 
This reverts commit 2ae602e.
@montezume montezume mentioned this pull request Jun 5, 2019
Merged
montezume added a commit that referenced this pull request Jun 5, 2019
@montezume
Revert "fix(toggle-input): toggle input disabled styles (#832)" (#833)
98747e7 
This reverts commit 2ae602e.
montezume added a commit that referenced this pull request Jun 5, 2019
@montezume
Revert "Revert "fix(toggle-input): toggle input disabled styles (#832)…
dfdf697 
…" (#833)"

This reverts commit 98747e7.
montezume added a commit that referenced this pull request Jun 5, 2019
@montezume
Revert "Revert "fix(toggle-input): toggle input disabled styles (#832)…
eacb0a6 
…" (#833)" (#834)

This reverts commit 98747e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@montezume montezume montezume approved these changes

Assignees

@jonnybel jonnybel

Labels
👨‍🎨 Status: UI/UX Review Requires review from design team 🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonnybel @montezume @mariabarrena @tdeekens