Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base-table): onSortChange being called without being passed #827

Merged
merged 1 commit into from
Jun 4, 2019
Merged

fix(base-table): onSortChange being called without being passed #827

merged 1 commit into from
Jun 4, 2019

Conversation

tdeekens
Copy link
Contributor

@tdeekens tdeekens commented Jun 4, 2019

Summary

This fixes onSortChange being called even if not passed as a prop (it's not required). As a result the component tree unmounts. This error occured 38 times to 3 users in our error logging.

@tdeekens tdeekens self-assigned this Jun 4, 2019
@tdeekens tdeekens requested review from montezume and jonnybel June 4, 2019 09:56
@tdeekens tdeekens added Semver: FIX 🐛 Type: Bug Something isn't working labels Jun 4, 2019
montezume
montezume approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@montezume montezume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@montezume montezume merged commit 0c45f89 into master Jun 4, 2019
@montezume montezume deleted the fix/base-table-on-sort-change branch June 4, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montezume montezume montezume approved these changes

@jonnybel jonnybel jonnybel approved these changes

Assignees

@tdeekens tdeekens

Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdeekens @montezume @jonnybel