Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio-input): do not use htmlFor if no id is passed #817

Merged
merged 1 commit into from
May 28, 2019
Merged

fix(radio-input): do not use htmlFor if no id is passed #817

merged 1 commit into from
May 28, 2019

Conversation

montezume
Copy link
Contributor

Fixes #570

@montezume montezume added the 🐛 Type: Bug Something isn't working label May 28, 2019
@montezume montezume requested review from emmenko and islam3zzat May 28, 2019 12:21
@montezume montezume self-assigned this May 28, 2019
@montezume montezume removed the request for review from islam3zzat May 28, 2019 12:54
@montezume montezume merged commit 95f2180 into master May 28, 2019
@montezume montezume deleted the ml-radio-input-bug branch May 28, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko approved these changes

@tdeekens tdeekens tdeekens approved these changes

Assignees

@montezume montezume

Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple RadioInput.Groups interfere with each other when id is not provided
3 participants
@montezume @emmenko @tdeekens