Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collapsible-panel): remove z-index #805

Merged
merged 1 commit into from
May 23, 2019
Merged

Conversation

montezume
Copy link
Contributor

@montezume montezume commented May 23, 2019

Summary

Currently when you have a above a CollapsiblePanel, the menu list is hidden by the CollapsiblePanel due to z-index setting. I don't believe we need to set a z-index here.

Screen Shot 2019-05-23 at 12 01 14 PM

Screen Shot 2019-05-23 at 11 44 42 AM

Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a fix or a breaking change?

@montezume
Copy link
Contributor Author

IMO it's a fix. We are changing internal styles of the CollapsiblePanel header.

@montezume montezume self-assigned this May 23, 2019
@montezume montezume added the 🐛 Type: Bug Something isn't working label May 23, 2019
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing styles can be seen as a breaking change of a component library. It's due to the API contract defined. A component/style guide doesn't only have a breaking change when code and usage changes but potentially also when visuals change. Just a thought.

@montezume
Copy link
Contributor Author

@jonnybel any thoughts ?

@montezume montezume requested a review from jonnybel May 23, 2019 11:00
@jonnybel
Copy link
Contributor

Well, it does constitute a breaking change, although it might not affect anything, it's hard to tell without seeing how it's being used all over our apps 🤔

But in doubt, it should be considered breaking. Perhaps we can add it to 10.0.0

@montezume
Copy link
Contributor Author

Well, it sets the z-index of a header container. I can't see how it could effect anything unless there was a CollapsiblePanel with some element inside that overlapped it's header container. I guess we can put it in 10.0.0, since nobody but me noticed the bug in the MC...

@tdeekens
Copy link
Contributor

We can release it as a normal fix. Sorry for making the buzz. It was more about raising awareness for how verionsing can be different on a ui library than this being an apt case for following it.

@montezume montezume merged commit a526942 into master May 23, 2019
@montezume montezume deleted the ml-colapsible-bug-fix branch May 23, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants