refactoring(time-input):TimeInput improvements
#776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
force-pushed
the
ml-time-input-improvements
branch
from
457843d to
20c2151
Compare
montezume
added
⛑ Type: Refactoring
👨🎨 Status: UI/UX Review
montezume
changed the title
TimeInput improvementsTimeInput improvements
jonnybel
approved these changes
May 16, 2019
| @@ -98,6 +98,7 @@ const getClockIconContainerStyles = (props, theme) => { | |||
| border-bottom-right-radius: ${overwrittenVars[ | |||
| designTokens.borderRadiusForInput | |||
| ]}; | |||
| transition: ${overwrittenVars.transitionStandard}; | |||
There was a problem hiding this comment.
We must remember to update these in version 10.0.0, to specify the properties to animate.
jonnybel
reviewed
May 16, 2019
| isReadOnly={this.props.isReadOnly} | ||
| hasError={this.props.hasError} |
There was a problem hiding this comment.
This was accidental, right? Better undo this to avoid the additional file being changed for nothing.
There was a problem hiding this comment.
hm? no I need hasError in the time-input-body
There was a problem hiding this comment.
This is the diff I'm seeing
So it was already there, just moved one line below? 😄
filippobocik
approved these changes
May 16, 2019
tdeekens
approved these changes
May 16, 2019
| &:hover ${StyledInput}, &:hover ${StyledClearSection}, &:hover ${StyledClockIconContainer} { | ||
| ${props => !props.isDisabled && getBorderColorWhenFocused} | ||
| } | ||
| `; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the look of the hover / focus for the
TimeInputBefore
After
Please check the deploy link