Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link-button): add hover effect for icon #752

Merged
merged 3 commits into from
May 9, 2019
Merged

fix(link-button): add hover effect for icon #752

merged 3 commits into from
May 9, 2019

Conversation

montezume
Copy link
Contributor

Summary

Fixes two bugs

  • When the LinkButton is hovered, both the text and the icon should change color.
  • When the LinkButton is disabled and hovered, the text should not change color.

Before

before
disabled-hover-befo

After

after
disabled-hover-after

@montezume montezume self-assigned this May 9, 2019
@montezume montezume requested a review from jonnybel May 9, 2019 12:15
@montezume montezume added the 🐛 Type: Bug Something isn't working label May 9, 2019
@montezume montezume merged commit f3fc29b into master May 9, 2019
@montezume montezume deleted the ml-link-button-hover-icon-fix branch May 9, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnybel jonnybel jonnybel approved these changes

Assignees

@montezume montezume

Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montezume @jonnybel