feat(selects): make selects inputs themable #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
May 3, 2019
| : base.borderTop, | ||
| }, | ||
| }); | ||
| const singleValueStyles = (props, theme) => (base, state) => { |
There was a problem hiding this comment.
this was the styles I added, because we weren't setting the input font color
montezume
commented
May 3, 2019
| showOptionGroupDivider: this.props.showOptionGroupDivider, | ||
| menuPortalZIndex: this.props.menuPortalZIndex, | ||
| })} | ||
| styles={createSelectStyles( |
There was a problem hiding this comment.
don't have access to emotion here, so don't have the theme object without injecting it
aminbenselim
approved these changes
May 3, 2019
tdeekens
approved these changes
May 3, 2019
islam3zzat
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the
withThemeHOC fromemotion-themingto pass our theme to the createSelectStyles functions to theme ourSelectInputs.