fix(time-input): readonly fix #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
approved these changes
May 2, 2019
|
@tdeekens I opened it as a draft so I could see the Percy diff and finish it up. 😢 |
montezume
commented
May 2, 2019
| value={this.props.value} | ||
| onChange={this.props.onChange} | ||
| onFocus={this.props.onFocus} | ||
| onBlur={this.props.onBlur} | ||
| {...filterDataAttributes(this.props)} | ||
| /* ARIA */ | ||
| role="textbox" | ||
| aria-readonly={this.props.isReadOnly} |
There was a problem hiding this comment.
same as we do in the TextInput
tdeekens
reviewed
May 2, 2019
| @@ -20,7 +20,7 @@ const getIconTheme = (isDisabled, isMouseOver) => { | |||
| export const ClearSection = props => ( | |||
| <div | |||
| onClick={props.isDisabled || props.isReadOnly ? undefined : props.onClear} | |||
| css={getClearSectionStyles(props)} | |||
| css={theme => getClearSectionStyles(props, theme)} | |||
There was a problem hiding this comment.
at least I have VRT to catch my mistakes 🙈
|
Just need to refactor the icons to use colors from css instead of Icon Themes to make theming work |
|
Actually a better way would just be to support Icon Theming. I'll do it in another PR though and put this on hold until then 🎈 |
montezume
force-pushed
the
ml-time-input-readonly
branch
from
00c28c3 to
f609809
Compare
jonnybel
pushed a commit
that referenced
this pull request
May 6, 2019
* fix(time-input): readonly fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRd does two things
isReadOnlyprop for theTimeInputcomponent.TimeInputcomponent to use design tokens and to be themeable.NOTE: Until we merge
10.0.0, a themed TimeInput looks a bit weird because the icons aren't themable.Closes #723