feat(select-inputs): let user override customized components #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Sep 18, 2018
| ...customizedComponents, | ||
| ...this.props.components, |
There was a problem hiding this comment.
Maybe I am just not getting the naming here. Customized are the ones you pass in? props.components are the ones the parent component passes as a default? Or the other way round? I guess that's why we swap the spread?
There was a problem hiding this comment.
Other way around. customizedComponents are those which customizied (compared to the defaults used by react-select) by ui-kit, and props.components are coming from the user of ui-kit SelectInput.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let user override pre-styled components in
*SelectInput-family of components.Description
My use case for that is to show
SearchIconinAsyncSelectInputinstead of defaultDropdownIndicator.