-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoComplete
to most inputs / fields.
#696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we just allow on
and off
while defaulting to off
or on
?
@tdeekens but modern browsers accept a whole whack of values for autocomplete... |
@@ -96,7 +96,8 @@ storiesOf('Examples|Forms/Fields', module) | |||
errors={formik.errors.animal} | |||
isRequired={true} | |||
touched={formik.touched.animal} | |||
name="animal" | |||
name="name" | |||
isSearchable={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
This is the type of prop that I'd personally prefer to spread directly to the HTML element in a But I know this would require a complete refactor of all inputs/fields (and even other components in our UI-kit), so I just wanted to state this for consideration. That being said, nothing wrong with this PR in particular considering how we're doing things so far 😄 |
@jonnybel really good point. It just adds noise to the component and especially to the readme the way it is now... |
@jonnybel do you want to open an issue and list the props that should be whitelisted for this spreading behaviour? I guess aria- props, etc... |
Yes, I can do that. |
Summary
Adds prop
autoComplete
to fields and inputs.