-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: releasing from master and release/* #689
Conversation
@@ -163,6 +163,10 @@ workflows: | |||
- publish: | |||
filters: | |||
tags: | |||
only: /^v.*/ | |||
only: /v[\.0-9]+.*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more explicit regex matching semver more.
branches: | ||
only: | ||
- master | ||
- /release\/.*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little escape hatch and also to have better releasing from branches if needed.
c79ed2a
to
98ff166
Compare
7d443e0
to
6f8e43c
Compare
Okay, I just pushed all variations and tags (and deleted them again) to figure it out (while having publishing halted by the circleci-agent). The docs are really freakish about this issue and everybody is in utter state of confusion. Essentially you:
Furthermore tags are located at the root of the project so here and can be easily missed. There you see a build for 10.0.0. Lastly, we can not check for the branch again as either branch of tag are set as CircleCI variables (this I picked up on another discussion in their forum). In all I think we can give this another try. I am pretty sure this makes more sense then what we had before. |
- vrt_test: | ||
requires: | ||
- build | ||
- publish: | ||
filters: | ||
tags: | ||
only: /^v.*/ | ||
requires: | ||
- bundle_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so bundle test needs filters because publish requires bundle test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and that game bubbles all the way up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given you do that you get a run with only those jobs when pushing a tag. The outcome it quite nice.
Summary
This pull request aims to experiment a bit more with the release process.