Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: releasing from master and release/* #689

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Conversation

tdeekens
Copy link
Contributor

Summary

This pull request aims to experiment a bit more with the release process.

@@ -163,6 +163,10 @@ workflows:
- publish:
filters:
tags:
only: /^v.*/
only: /v[\.0-9]+.*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more explicit regex matching semver more.

branches:
only:
- master
- /release\/.*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little escape hatch and also to have better releasing from branches if needed.

@tdeekens tdeekens force-pushed the release/change-releasing branch 3 times, most recently from c79ed2a to 98ff166 Compare April 16, 2019 18:32
@tdeekens tdeekens force-pushed the release/change-releasing branch from 7d443e0 to 6f8e43c Compare April 16, 2019 18:35
@tdeekens
Copy link
Contributor Author

Okay, I just pushed all variations and tags (and deleted them again) to figure it out (while having publishing halted by the circleci-agent).

The docs are really freakish about this issue and everybody is in utter state of confusion. Essentially you:

  1. Need to mark the tag filters all the way up as otherwise the jobs dependencies are not satisfied (even if you push a tag) and it won't run
  2. You need to specify the branch dependency on the job too and check the tag again as otherwise it runs too often

Furthermore tags are located at the root of the project so here and can be easily missed. There you see a build for 10.0.0.

Screenshot 2019-04-16 at 20 36 12

Lastly, we can not check for the branch again as either branch of tag are set as CircleCI variables (this I picked up on another discussion in their forum).

Screenshot 2019-04-16 at 20 37 35

In all I think we can give this another try. I am pretty sure this makes more sense then what we had before.

- vrt_test:
requires:
- build
- publish:
filters:
tags:
only: /^v.*/
requires:
- bundle_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah so bundle test needs filters because publish requires bundle test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and that game bubbles all the way up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given you do that you get a run with only those jobs when pushing a tag. The outcome it quite nice.

@tdeekens tdeekens merged commit 7a7f8da into master Apr 17, 2019
@tdeekens tdeekens deleted the release/change-releasing branch April 17, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants