fix: change high precision money display #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Apr 9, 2019
src/components/tooltip/README.md
Outdated
| @@ -111,3 +111,4 @@ In the following example, the tooltip text only appears on hover when the button | |||
| | `horizontalConstraint` | `object` | - | `xs`, `s`, `m`, `l`, `xl`, `scale` | `scale` | Horizontal size limit of the tooltip | | |||
| | `children` | `node` | ✅ | - | - | Content rendered within the tooltip | | |||
| | `components` | `object` | - | `WrapperComponent`, `BodyComponent` | - | If passed, the tooltip will wrap your component with this element | | |||
| | `customBodyStyles` | `object` | - | - | - | If passed, these styles will be spread onto the div surrounding the tooltip body | | |||
There was a problem hiding this comment.
Not sure if I am overly picky with the name again. But given we tend to like the components={{header, footer}} pattern. How about going with styles={ body } here?
tdeekens
reviewed
Apr 9, 2019
src/components/tooltip/README.md
Outdated
| @@ -111,4 +111,4 @@ In the following example, the tooltip text only appears on hover when the button | |||
| | `horizontalConstraint` | `object` | - | `xs`, `s`, `m`, `l`, `xl`, `scale` | `scale` | Horizontal size limit of the tooltip | | |||
| | `children` | `node` | ✅ | - | - | Content rendered within the tooltip | | |||
| | `components` | `object` | - | `WrapperComponent`, `BodyComponent` | - | If passed, the tooltip will wrap your component with this element | | |||
| | `customBodyStyles` | `object` | - | - | - | If passed, these styles will be spread onto the div surrounding the tooltip body | | |||
| | `styles` | `object` | - | - | - | If passed, these styles will be spread onto the div surrounding the tooltip body | | |||
islam3zzat
reviewed
Apr 10, 2019
| getAmountInputStyles({ ...this.props, hasFocus }), | ||
| // accounts for size of icon | ||
| css` | ||
| padding-right: 24px; |
There was a problem hiding this comment.
Suggested change
| padding-right: 24px; | |
| padding-right: ${vars.spacing24}; |
| @@ -111,3 +111,4 @@ In the following example, the tooltip text only appears on hover when the button | |||
| | `horizontalConstraint` | `object` | - | `xs`, `s`, `m`, `l`, `xl`, `scale` | `scale` | Horizontal size limit of the tooltip | | |||
| | `children` | `node` | ✅ | - | - | Content rendered within the tooltip | | |||
| | `components` | `object` | - | `WrapperComponent`, `BodyComponent` | - | If passed, the tooltip will wrap your component with this element | | |||
| | `styles.body` | `object` | - | - | - | If passed, these styles will be spread onto the div surrounding the tooltip body | | |||
There was a problem hiding this comment.
the proptypes says it's required.
Should we update the propTypes, or the readme?
There was a problem hiding this comment.
it's required because it's set with a default though, so for the user it's not required.
There was a problem hiding this comment.
thanks for the explanation
islam3zzat
approved these changes
Apr 10, 2019
montezume
added
👨🎨 Status: UI/UX Review
tdeekens
reviewed
Apr 10, 2019
| @@ -29,4 +29,20 @@ const getAmountInputStyles = props => [ | |||
| `, | |||
| ]; | |||
|
|
|||
| export { getCurrencyLabelStyles, getAmountInputStyles }; | |||
| const getHighPrecisionWrapperStyles = props => css` | |||
There was a problem hiding this comment.
Nit just pass isDisabled? to be more specific? Not sure what the pattern is on UIKit.
tdeekens
approved these changes
Apr 10, 2019
montezume
force-pushed
the
ml-high-precision-money
branch
from
116a248 to
d90361f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when a price is
highPrecision, the MoneyField "jumps", as it is rendering a label above the field. This is not desired. Instead, we replace it with the use of an icon, and an accompanying tooltip in the MoneyInput.Before
After
Also adds new
FractionDigitsIcon