feat(text): allow to pass intl message instead of children #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Apr 5, 2019
| title: nonEmptyString, | ||
| truncate: PropTypes.bool, | ||
| intlMessage: intlMessageShape, |
There was a problem hiding this comment.
Should this be flipped to the case below. Given there are no children then this?
emmenko
force-pushed
the
nm-text-intl-message
branch
from
4b50b10 to
656a49a
Compare
|
Can you add the new VRT's at the end to make reviewing easier 🙏 |
emmenko
force-pushed
the
nm-text-intl-message
branch
from
656a49a to
bc69eda
Compare
emmenko
force-pushed
the
nm-text-intl-message
branch
from
bc69eda to
11662e1
Compare
|
@montezume do you want to review/approve the VRT? |
|
@emmenko 👍 done |
montezume
approved these changes
Apr 5, 2019
tdeekens
approved these changes
Apr 5, 2019
| title: nonEmptyString, | ||
| truncate: PropTypes.bool, | ||
| intlMessage: requiredIf(intlMessageShape, props => !props.children), | ||
| children: requiredIf(PropTypes.node, props => !props.intlMessage), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #637