Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use tshirt sizes for spacings #645

Merged
merged 1 commit into from
Apr 5, 2019
Merged

feat: use tshirt sizes for spacings #645

merged 1 commit into from
Apr 5, 2019

Conversation

montezume
Copy link
Contributor

Summary

As suggested by @emmenko, I propose that we introduce the following tshirt sizing for spacings.

old new value
spacing-4 spacing-xs 4px
spacing-8 spacing-s 8px
spacing-16 spacing-m 16px
spacing-24 spacing-l 24px
spacing-32 spacing-xl 32px

This will make theming of these margins and paddings make more sense.

@montezume montezume requested review from emmenko and tdeekens and removed request for emmenko April 5, 2019 09:11
@montezume montezume self-assigned this Apr 5, 2019
emmenko
emmenko approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@montezume montezume merged commit 0b3c7a8 into master Apr 5, 2019
@montezume montezume deleted the ml-tshirt-spacings branch April 5, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko approved these changes

@tdeekens tdeekens tdeekens approved these changes

Assignees

@montezume montezume

Labels
🚀 Type: New Feature Something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montezume @emmenko @tdeekens