fix: LinkButton to use inline TextBody #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Apr 2, 2019
jonnybel
force-pushed
the
ja-fix-linkbutton-tag
branch
from
341202c to
d2d1094
Compare
montezume
reviewed
Apr 2, 2019
| @@ -94,6 +94,7 @@ Wraps the given text in a `<p>` element, for normal content. | |||
| | `children` | `PropTypes.node` | ✅ | - | - | | |||
| | `title` | `String` | - | - | - | | |||
| | `truncate` | `Bool` | - | - | `false` | | |||
| | `isInline` | `Bool` | - | - | `false` | | |||
There was a problem hiding this comment.
This is the README of the Text component, I think the props was missing from the documentation...right?
There was a problem hiding this comment.
Yes, it was already being used, just not documented.
emmenko
approved these changes
Apr 2, 2019
tdeekens
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Text.BodyandText.Detailto include theisInlineprop.Description
There is still a problem with the
LinkButtonrendering adiv(from theSpacings.Inlinewrapper), which inside apis also an invalid DOM nesting. I shall address this in a follow-up PR.