Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(circleci): releasing to next #619

Merged
merged 2 commits into from
Mar 29, 2019
Merged

fix(circleci): releasing to next #619

merged 2 commits into from
Mar 29, 2019

Conversation

tdeekens
Copy link
Contributor

@tdeekens tdeekens commented Mar 29, 2019

Summary

On CircleCI we currently attempt to release from master without a tag. Which fails as the previous version already exists.

Given this configuration:

workflows:
  version: 2
  build-n-deploy:
    jobs:
      - build:
          filters:  # required since `deploy` has tag filters AND requires `build`
            tags:
              only: /.*/
      - deploy:
          requires:
            - build
          filters:
            tags:
              only: /^v.*/
            branches:
              ignore: /.*/
  • The build job runs for all branches and all tags.
  • The deploy job runs for no branches and only for tags starting with ‘v’.

@tdeekens tdeekens requested a review from montezume March 29, 2019 15:31
@tdeekens tdeekens self-assigned this Mar 29, 2019
@tdeekens tdeekens added 🐛 Type: Bug Something isn't working Semver: UNRELATED labels Mar 29, 2019
@tdeekens tdeekens merged commit fbea050 into master Mar 29, 2019
@tdeekens tdeekens deleted the chore/fix-next-release branch March 29, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants