feat(tooltip): add option for tooltip wrapper #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Feb 21, 2019
| // should not render the tooltip inside of the main div\ | ||
| const mainContainer = container.querySelector('#main'); | ||
| expect( | ||
| mainContainer.querySelector("[data-testid='tooltip-custom-body']") |
There was a problem hiding this comment.
this is a cool part about react-testing-library
montezume
commented
Feb 21, 2019
| // should render the tooltip inside of the portal | ||
| const portalContainer = container.querySelector('#portal-id'); | ||
| expect( | ||
| portalContainer.querySelector("[data-testid='tooltip-custom-body']") |
tdeekens
reviewed
Feb 21, 2019
src/components/tooltip/tooltip.js
Outdated
| @@ -51,6 +59,14 @@ class Tooltip extends React.Component { | |||
| } | |||
| return null; | |||
| }, | |||
| PopperWrapperComponent: (props, propName) => { | |||
There was a problem hiding this comment.
🤔 aren't we leaking implementation details with this name? The fact that we use popper?
There was a problem hiding this comment.
🤔 yeah makes sense.
How about TooltipWrapperComponent?
montezume
changed the title
emmenko
approved these changes
Feb 21, 2019
src/components/tooltip/tooltip.js
Outdated
| @@ -180,7 +196,8 @@ class Tooltip extends React.Component { | |||
|
|
|||
| const WrapperComponent = this.props.components.WrapperComponent || Wrapper; | |||
| const BodyComponent = this.props.components.BodyComponent || Body; | |||
|
|
|||
| const TooltipWrapper = | |||
There was a problem hiding this comment.
Nitpick: to keep it consistent with the other variable names
- rename variable
TooltipWrapper-->TooltipWrapperComponent - rename component
TooltipWrapperComponent-->TooltipWrapper
tdeekens
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds another
componentprop to theTooltipcomponent,TooltipWrapperComponent. This can be used along withReactDOM.renderPortalto render the Tooltip to another place inside of the document. This is useful when dealing with virtualized items, like our table.The following example uses a simple
TooltipWrapperComponentthat renders the portal as a descendent ofdocument.body.Before
After