Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): do not apply padding to outer flex container #556

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Feb 19, 2019

Fixes #554

background: ${props.theme === 'dark'
? vars.colorGray95
: vars.colorWhite};
`,
]}
className={props.className}
>
{props.children}
<div
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious: styled.div?

Copy link
Contributor

@qmateub qmateub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me ✌️

The percy diff perfectly illustrates the change 💯

@emmenko emmenko merged commit 65b150e into master Feb 19, 2019
@emmenko emmenko deleted the nm-fix-card-flex-padding branch February 19, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants