feat: use design tokens for text-input #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Jan 17, 2019
| @@ -1,19 +1,13 @@ | |||
| /* Base */ | |||
|
|
|||
| .container { | |||
There was a problem hiding this comment.
this didn't do anything
montezume
requested review from
dferber90 and
tdeekens
and removed request for
dferber90
tdeekens
approved these changes
Jan 17, 2019
|
I also did |
|
|
tdeekens
approved these changes
Jan 17, 2019
emmenko
approved these changes
Jan 18, 2019
| label: Font sizes | ||
| prefix: font-size | ||
| choices: | ||
| font-size-m: '13px' |
There was a problem hiding this comment.
The size I suppose, so medium.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Talking about tokens is nice. But it's not really enough.
Approach
Use design tokens in the
TextInputcomponent.Since we are using
yamlfor our design token definition file, we also set prettier to format our yaml files.