Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(time-input): call onChange with generated ID if none passed #427

Merged
merged 1 commit into from
Jan 11, 2019
Merged

fix(time-input): call onChange with generated ID if none passed #427

merged 1 commit into from
Jan 11, 2019

Conversation

montezume
Copy link
Contributor

Summary

If TimeInput is used without an id prop, we should call onChange with the generated sequential id.

@montezume montezume requested a review from dferber90 January 11, 2019 10:12
@montezume montezume self-assigned this Jan 11, 2019
@montezume montezume added 🐛 Type: Bug Something isn't working Semver: FIX labels Jan 11, 2019
@montezume montezume requested a review from tdeekens January 11, 2019 10:13
dferber90
dferber90 approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@dferber90 dferber90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@montezume montezume merged commit 7bbc6c6 into master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dferber90 dferber90 dferber90 approved these changes

@tdeekens tdeekens tdeekens approved these changes

Assignees

@montezume montezume

Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montezume @dferber90 @tdeekens