fix(radio-option, checkbox, switch): move data-attributes to input #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Jan 10, 2019
| @@ -18,6 +18,9 @@ class TestComponent extends React.Component { | |||
| props, | |||
| ...rest | |||
| ), | |||
| loadOptions: PropTypes.func, | |||
| defaultOptions: PropTypes.bool, | |||
There was a problem hiding this comment.
Is this a bool or object?
There was a problem hiding this comment.
it was set as a bool in the existing defaultProps
There was a problem hiding this comment.
It can either be an array of objects (options) or a boolean, see react-select docs.
tdeekens
approved these changes
Jan 10, 2019
dferber90
approved these changes
Jan 10, 2019
montezume
force-pushed
the
ml-fix-warnings
branch
from
c4ad203 to
55f7fe3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you run
yarn linton the master branch, we get a bunch of errors.This PR fixes those errors.
It also moves the
filter-data-attributesonSwitch,RadioOptionandCheckboxto the underlying input.