Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(money-field): remove required currencies prop from #422

Merged
merged 2 commits into from
Jan 10, 2019
Merged

fix(money-field): remove required currencies prop from #422

merged 2 commits into from
Jan 10, 2019

Conversation

montezume
Copy link
Contributor

Summary

currencies shouldn't be a required prop for MoneyField, since MoneyInput provides a defaultValue for this prop.

@montezume montezume requested review from dferber90 and tdeekens and removed request for dferber90 January 10, 2019 14:15
@montezume montezume self-assigned this Jan 10, 2019
@montezume montezume requested a review from dferber90 January 10, 2019 14:37
dferber90
dferber90 approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@dferber90 dferber90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🥇

@montezume montezume merged commit c05d9da into master Jan 10, 2019
@montezume montezume deleted the ml-fix-proptypes branch January 10, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dferber90 dferber90 dferber90 approved these changes

@tdeekens tdeekens tdeekens approved these changes

Assignees

@montezume montezume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montezume @dferber90 @tdeekens