feat(notifications/static): add ContentNotification component #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pa3
force-pushed
the
pa3-static-notifications
branch
from
16af794 to
7366966
Compare
pa3
commented
Nov 14, 2018
dferber90
suggested changes
Nov 14, 2018
src/components/notifications/static/__snapshots__/static.spec.js.snap
Outdated
Show resolved
Hide resolved
pa3
force-pushed
the
pa3-static-notifications
branch
from
7366966 to
3401951
Compare
dferber90
changed the title
dferber90
approved these changes
Nov 16, 2018
| | Props | Type | Required | Values | Default | Description | | ||
| | ---------- | -------- | :------: | ------------------------------------- | ------- | ------------------------------------------------- | | ||
| | `children` | `node` | - | - | - | Message to be shown inside a notification panel. | | ||
| | `type` | `string` | - | `success`, `info`, `warning`, `error` | - | Type of notification, determining its appearance. | |
There was a problem hiding this comment.
@mariabarrena Can we include some guidelines (Dos & Don'ts) here on when to use ContentNotifications over SideNotifications ? What's your take on it? :)
| else if (this.props.type === 'info') InfoIcon; | ||
| else if (this.props.type === 'warning') WarningIcon; | ||
| else SuccessIcon; | ||
| }; |
…ificaiton; remove dumb tests; fix storybook story;
dferber90
force-pushed
the
pa3-static-notifications
branch
from
3401951 to
db74842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add in-place notification panel component.