fix(money-input): avoid rounding errors #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dferber90
force-pushed
the
df-fix-money-value-rounding
branch
from
d937dc6 to
ea778a6
Compare
adnasa
approved these changes
Nov 12, 2018
| // to the nearest decimal value | ||
| // ref: https://github.com/commercetools/merchant-center-frontend/pull/770 | ||
| const centAmount = Math.trunc( | ||
| Math.round(amountAsNumber * 10 ** currency.fractionDigits) |
dferber90
force-pushed
the
df-fix-money-value-rounding
branch
from
ea778a6 to
3065656
Compare
adnasa
reviewed
Nov 12, 2018
| }); | ||
|
|
||
| // This test ensures that rounding is used instead of just cutting the | ||
| // number of. Cutting it of would result in an incorrect 239998. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users selected the currency EUR (or any other with 2 fraction digits) and typed certain numbers like
2.49, theMoneyInput.convertToMoneyValuewould determine an incorrectcentAmountdue to rounding errors as @adnasa hinted at in #221 (comment).This PR fixes that by ensuring
centAmountis an integer.