fix(*-select-input): align indicator icons of clearable select-inputs #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dferber90
added
🐛 Type: Bug
dferber90
commented
Oct 26, 2018
| </div> | ||
| </div> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
This restyled component enables us to keep overwriting the styles through the styles={} prop on Select itself. Previously the ClearIndicator would just ignore all custom styling.
| @@ -72,7 +72,6 @@ const indicatorSeparatorStyles = () => base => ({ | |||
| const dropdownIndicatorStyles = () => base => ({ | |||
| ...base, | |||
| color: vars['--token-font-color-default'], | |||
| marginRight: vars['--spacing-8'], | |||
There was a problem hiding this comment.
There wasn't really a point in defining marginRight when we overwrite it with 0 in the next line.
dferber90
changed the title
dferber90
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes alignment of indicator icons in
SelectInput,CreatableSelectInput,AsyncSelectInput&AsyncCreatableSelectInputafter it broke in #182.Before
After
I also changed both icons to have size
medium. Previously one wassmalland the other wasmedium.