Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow scrolling in icon story #189

Merged
merged 1 commit into from
Oct 25, 2018
Merged

fix: allow scrolling in icon story #189

merged 1 commit into from
Oct 25, 2018

Conversation

montezume
Copy link
Contributor

@montezume montezume commented Oct 25, 2018

Summary

Before #186 , we had

import '../materials/internals/reset.mod.css';	
import './main.mod.css';	

This meant that the overflow: auto took precedence over overflow: hidden in reset.mod.css.

By importing reset.mod.css in index.js, this order of precedence changed.

Approach

Remove overflow: hidden in reset.mod.css because this shouldn't be in UI-Kit anyways.

Release notes Consumers which were relying on overflow: hidden on body now need to define this themselves.

@montezume montezume added the 🐛 Type: Bug Something isn't working label Oct 25, 2018
@montezume montezume self-assigned this Oct 25, 2018
@montezume montezume requested a review from dferber90 October 25, 2018 08:25
@montezume montezume merged commit a6b4b3b into master Oct 25, 2018
@montezume montezume deleted the ml-fix-icon-story branch October 25, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants