fix: replace styled-components with react-emotion #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Oct 23, 2018
| // so that they do not end up in the bundle. | ||
| // See also https://medium.com/@kelin2025/so-you-wanna-use-es6-modules-714f48b3a953 | ||
| peerDepsExternal(), | ||
| peerDepsExternal({ | ||
| dependencies: true, |
There was a problem hiding this comment.
if this is a reasonable default for KCD, it's good enough for us?
There was a problem hiding this comment.
Didn't we had this before and then it got removed?
I'm fine having this btw 😉
There was a problem hiding this comment.
Yes, I misunderstood how it worked 😢. I think it's better now. If we had UMD bundles, it would make sense to bundle non peer deps.
montezume
force-pushed
the
ml-replace-sc
branch
from
a9ea07c to
67818fa
Compare
montezume
force-pushed
the
ml-replace-sc
branch
from
67818fa to
fe39401
Compare
Drops direct usage of emotion. Drops emotion as a peer-dep as we're not using it directly anymore.
dferber90
force-pushed
the
ml-replace-sc
branch
from
980a389 to
25bdce4
Compare
emmenko
approved these changes
Oct 23, 2018
| // so that they do not end up in the bundle. | ||
| // See also https://medium.com/@kelin2025/so-you-wanna-use-es6-modules-714f48b3a953 | ||
| peerDepsExternal(), | ||
| peerDepsExternal({ | ||
| dependencies: true, |
There was a problem hiding this comment.
Didn't we had this before and then it got removed?
I'm fine having this btw 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Storybook in production was broken since we removed
styled-components.Approach
react-emotionis pretty much a plug and play replacement for how we are using sc. Let's use that instead.