feat: bundle small deps, explicitly peer dep others. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
force-pushed
the
ml-peer-deepify
branch
from
fa4e176 to
a82d5a8
Compare
tdeekens
approved these changes
Oct 10, 2018
emmenko
approved these changes
Oct 10, 2018
|
@dferber90 anything from your side? |
montezume
force-pushed
the
ml-peer-deepify
branch
from
a82d5a8 to
ad9a869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now we are treating every single dependancy as a peer dep. This isn't sustainable, since users don't want to install a small lodash module everytime we add one. It only makes sense to treat large dependencies as peer dependencies.
Approach
flatpickr,react-select,react-textarea-autosize,react-virtualizedandstyled-componentsare moved to peer deps, the rest stay as deps, and remove the rollup config that treats all deps as peer deps.This increases the bundle size from 614kb -> 813kb, but I think the trade off is worth it.